Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNGSITE-281: update introduction to lifecycle with current practice r… #4

Closed
wants to merge 2 commits into from

Conversation

chonton
Copy link
Member

@chonton chonton commented Apr 27, 2016

Using integration-test as the target from the command line doesn't do what many users expect. The failsafe plugin does not report on results until the verify phase. The cargo and tomcat plugins require at least the post-integration-test phase to be run else the web containers are not stopped. Jacoco does not collect coverage data until post-integration-test. For these situations, it no longer is a useful practice to run integration-test as the command line target. I recommend updating the introduction to remove integration-test as one of the featured phases in the {A Build Lifecycle is Made Up of Phases} section.

@mfriedenhagen
Copy link
Contributor

Hello @chonton, I could imagine that the section "mvn integration-test" should be updated as well, there it should probably be outlined that the result of the integrative tests and post-integration-test goals are not executed. What do you think?

@chonton
Copy link
Member Author

chonton commented Apr 27, 2016

Hopefully these edits represent a news style writing. The important information is concisely in the lead paragraph, and detail information is in following expository paragraphs.

The developer first wants simple recipes mvn install, mvn clean deploy.

@chonton
Copy link
Member Author

chonton commented Apr 27, 2016

I was unable to build site locally. Are there instructions somewhere?

@mfriedenhagen
Copy link
Contributor

It seems the project references an unreleased maven-parent, I had to adapt this to use the latest release (http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.apache.maven%22%20AND%20a%3A%22maven-parent%22) 27.

@mfriedenhagen
Copy link
Contributor

mfriedenhagen commented Apr 28, 2016

Hello @chonton, I updated the trunk at http://svn.apache.org/viewvc?view=revision&revision=1741510, thanks. You may close this now 😀

asfgit pushed a commit that referenced this pull request Apr 28, 2016
…t practice wrt integration-test.

Patch submitted by Chas Honton in #4.


git-svn-id: https://svn.apache.org/repos/asf/maven/site/trunk@1741510 13f79535-47bb-0310-9956-ffa450edef68
@chonton
Copy link
Member Author

chonton commented Apr 29, 2016

thanks for merging to trunk

@chonton chonton closed this Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants