Skip to content

Conversation

@Tibor17
Copy link
Contributor

@Tibor17 Tibor17 commented Nov 9, 2025

According to the build result we have found out that the test failed (ForkedBooterTest.testThreadDump:190 NullPointer), the build crashed but we have no Artifact for the analysis.
We are missing a lots of files in the archive. Currently we can see only some XML reports of the ITs but that's not enough for the complete analysis. We are missing logs, dump files, etc. We are missing unit tests, and another ITs from the Failsafe module.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@asf-gitbox-commits asf-gitbox-commits force-pushed the tibor17-gh-workflows-path branch from 86134c0 to 9097239 Compare November 9, 2025 02:43
@Tibor17 Tibor17 changed the title Missing many files in the GH Artifacts of CI ex-post. Build timeout is too short. Missing many files in the GH Artifacts of CI ex-post. Build timeout is too long. Nov 9, 2025
surefire-its/target/**/surefire-reports/*
surefire-its/target/**/failsafe-reports/*
timeout-minutes: 600
maven-surefire/**/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paths are related to project workspace ....
so there is no directory maven-surefire

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can try to add something like:

        **/target/*/log.txt
        **/target/**/surefire-reports/*
        **/target/**/failsafe-reports/*

so we will have included logs, reports from all modules

Copy link
Contributor Author

@Tibor17 Tibor17 Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was googling a bit and I found this structure could be generated in the runner .../maven-surefire/maven-surefire/... Let me please just break some test to see what would happen in the archive because I am also not sure. I have expected the ForkedBooterTest to fail. So let's break it now, see the archive content, and then I would take it back.

@slawekjaranowski
Copy link
Member

According to the build result we have found out that the test failed (ForkedBooterTest.testThreadDump:190 NullPointer), the build crashed but we have no Artifact for the analysis.

Currently we save result only from ITs test ... from surefire-its module ... so when some module failed before IT we have empty archive

@Tibor17
Copy link
Contributor Author

Tibor17 commented Nov 9, 2025

According to the build result we have found out that the test failed (ForkedBooterTest.testThreadDump:190 NullPointer), the build crashed but we have no Artifact for the analysis.

Currently we save result only from ITs test ... from surefire-its module ... so when some module failed before IT we have empty archive

Exactly. That's my point. Empty archive, or no existence of the archive was the reason why I opened this PR.
In Jenkins we observed everything and there was no problem to make the analysis. Currently, it is not possible because we don't have a relevant information from other modules. We don't have any results from unit tests. It does not mean that other modules except surefire-its have unit tests. The Failsafe has ITs as well.

@asf-gitbox-commits asf-gitbox-commits force-pushed the tibor17-gh-workflows-path branch 3 times, most recently from cb32eac to 1d855e5 Compare November 11, 2025 09:25
@Tibor17
Copy link
Contributor Author

Tibor17 commented Nov 11, 2025

@slawekjaranowski I have squashed the commits in one and dropped the fake test which forcibly failed.

!**/*.zip
!**/target/site/*
!**/target/staging/*
timeout-minutes: 180
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timeout can be done a simple separate PR

Comment on lines 39 to 48
timeout-minutes: 600
**/*
!**/pom.xml
!**/*.java
!**/*.class
!**/*.jar
!**/*.war
!**/*.tar.gz
!**/*.tgz
!**/*.zip
!**/target/site/*
!**/target/staging/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still not sure if we need everything eg, I see many files from source in archive ... do we need all

Image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure if we need all those files ... in archive

@Tibor17 Tibor17 changed the title Missing many files in the GH Artifacts of CI ex-post. Build timeout is too long. Missing many files in the GH Artifacts of CI ex-post. Nov 15, 2025
@Tibor17
Copy link
Contributor Author

Tibor17 commented Nov 17, 2025

@slawekjaranowski so, i can proceed with this if there are no objections. Thx

@Tibor17 Tibor17 merged commit 298e507 into master Nov 21, 2025
27 checks passed
@Tibor17 Tibor17 deleted the tibor17-gh-workflows-path branch November 21, 2025 15:50
@github-actions github-actions bot added this to the 3.5.5 milestone Nov 21, 2025
@github-actions
Copy link

@Tibor17 Please assign appropriate label to PR according to the type of change.

@Tibor17 Tibor17 added the build Pull requests that change the build process label Nov 21, 2025
@olamy
Copy link
Member

olamy commented Nov 22, 2025

@slawekjaranowski so, i can proceed with this if there are no objections. Thx

there was a question here https://github.com/apache/maven-surefire/pull/3219/files#r2534891172

not sure why *.java or even *.class are needed

@slawekjaranowski
Copy link
Member

@slawekjaranowski so, i can proceed with this if there are no objections. Thx

there was a question here https://github.com/apache/maven-surefire/pull/3219/files#r2534891172

not sure why *.java or even *.class are needed

*.java , *.class are excluded ... but there are many other not needed files, like I show in my questions in thread

@olamy
Copy link
Member

olamy commented Nov 22, 2025

@slawekjaranowski so, i can proceed with this if there are no objections. Thx

there was a question here https://github.com/apache/maven-surefire/pull/3219/files#r2534891172
not sure why *.java or even *.class are needed

*.java , *.class are excluded ... but there are many other not needed files, like I show in my questions in thread

oh right sorry I didn't read the diff correctly.
Would be better to configure what we need/want rather than upload everything but those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Pull requests that change the build process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants