-
Notifications
You must be signed in to change notification settings - Fork 559
Missing many files in the GH Artifacts of CI ex-post. #3219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
86134c0 to
9097239
Compare
.github/workflows/maven-verify.yml
Outdated
| surefire-its/target/**/surefire-reports/* | ||
| surefire-its/target/**/failsafe-reports/* | ||
| timeout-minutes: 600 | ||
| maven-surefire/**/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paths are related to project workspace ....
so there is no directory maven-surefire
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can try to add something like:
**/target/*/log.txt
**/target/**/surefire-reports/*
**/target/**/failsafe-reports/*
so we will have included logs, reports from all modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was googling a bit and I found this structure could be generated in the runner .../maven-surefire/maven-surefire/... Let me please just break some test to see what would happen in the archive because I am also not sure. I have expected the ForkedBooterTest to fail. So let's break it now, see the archive content, and then I would take it back.
Currently we save result only from ITs test ... from |
Exactly. That's my point. Empty archive, or no existence of the archive was the reason why I opened this PR. |
cb32eac to
1d855e5
Compare
|
@slawekjaranowski I have squashed the commits in one and dropped the fake test which forcibly failed. |
.github/workflows/maven-verify.yml
Outdated
| !**/*.zip | ||
| !**/target/site/* | ||
| !**/target/staging/* | ||
| timeout-minutes: 180 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timeout can be done a simple separate PR
| timeout-minutes: 600 | ||
| **/* | ||
| !**/pom.xml | ||
| !**/*.java | ||
| !**/*.class | ||
| !**/*.jar | ||
| !**/*.war | ||
| !**/*.tar.gz | ||
| !**/*.tgz | ||
| !**/*.zip | ||
| !**/target/site/* | ||
| !**/target/staging/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not sure if we need all those files ... in archive
3567b5d to
d940d74
Compare
|
@slawekjaranowski so, i can proceed with this if there are no objections. Thx |
|
@Tibor17 Please assign appropriate label to PR according to the type of change. |
there was a question here https://github.com/apache/maven-surefire/pull/3219/files#r2534891172 not sure why |
*.java , *.class are excluded ... but there are many other not needed files, like I show in my questions in thread |
oh right sorry I didn't read the diff correctly. |

According to the build result we have found out that the test failed (ForkedBooterTest.testThreadDump:190 NullPointer), the build crashed but we have no Artifact for the analysis.
We are missing a lots of files in the archive. Currently we can see only some XML reports of the ITs but that's not enough for the complete analysis. We are missing logs, dump files, etc. We are missing unit tests, and another ITs from the Failsafe module.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.