Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer Guice injection #79

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Prefer Guice injection #79

merged 2 commits into from
Dec 26, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Dec 19, 2024

No description provided.

@elharo elharo marked this pull request as ready for review December 19, 2024 22:23
@elharo elharo requested a review from slachiewicz December 19, 2024 22:23
@slachiewicz slachiewicz removed their request for review December 22, 2024 16:43
Bukama
Bukama approved these changes Dec 25, 2024
View reviewed changes
Copy link

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non binding approval

@elharo elharo merged commit 1e267a6 into master Dec 26, 2024
51 checks passed
@elharo elharo deleted the guice branch December 26, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slachiewicz slachiewicz slachiewicz approved these changes

@Bukama Bukama Bukama approved these changes

@slawekjaranowski slawekjaranowski Awaiting requested review from slawekjaranowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elharo @Bukama @slachiewicz