-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWRAPPER-129][MWRAPPER-128] Drop legacy stuff, require Maven 3.6.3+ #126
Conversation
Also refresh and reshuffle to not duplicate dependencies and versions. Tend to use properties for versions where there is 2+ of them, otherwise is just fluff. --- https://issues.apache.org/jira/browse/MWRAPPER-128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The org.codehaus.plexus:plexus-io dependency seems that is not used.
maven-wrapper-plugin/pom.xml
Outdated
@@ -34,7 +34,7 @@ under the License. | |||
<description>The Maven Wrapper Plugin is a plugin that provides support for the Maven Wrapper by unpacking Maven Wrapper Distribution to the current project.</description> | |||
|
|||
<prerequisites> | |||
<maven>${mavenVersion}</maven> | |||
<maven>3.2.5</maven> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 3.6.3? this PR is about dropping legacy stuff ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I did not want to change prerequisite, it was more to kill this antipattern to "compile against eons old" maven that prevents noticing what is being deprecated lately in APIs and Core... (and replaced eon old aether w/ maven-resolver)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not sure about it ... when we depend on newer version we can have some issues in runtime which is not cover by ITs.
But from other side we have more information about depractions ...
The perfect way will be for me depends on the same version as in in prerequisites ... but we block using plugin for older Maven ....
So we need a compromise on it 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but we should be consequential and put here 3.6.3 as we do in more of plugins now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but all plugin builds use at least two Maven version: 3.9.6 and ... usually 3.6.3. So what "issue in runtime" you expect? Okay, if test coverage is poor... but then we fix and improve coverage, and life goes on...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add to commit message and issue title, that we also require 3.6.3 to be clear in release notes
Tomorrow will check is plexus-io really used or not.... |
Maybe is used transitively, so never mind. |
Hm, removed it and it builds... |
Yes, is used:
|
Also refresh and reshuffle to not duplicate dependencies and versions. Tend to use properties for versions where there is 2+ of them, otherwise is just fluff.
https://issues.apache.org/jira/browse/MWRAPPER-128
https://issues.apache.org/jira/browse/MWRAPPER-129