Fix concurrency issue in DefaultModelValidator (#1786)

apache · Oct 8, 2024 · a6ecbde · a6ecbde
1 parent 954eae7
commit a6ecbde
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 16 deletions.
diff --git a/maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelValidator.java b/maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelValidator.java
@@ -30,6 +30,7 @@
 import java.util.Objects;
 import java.util.Optional;
 import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
 import java.util.function.Function;
 import java.util.function.Supplier;
 import java.util.function.UnaryOperator;
@@ -283,9 +284,9 @@ protected ActivationProperty.Builder transformActivationProperty_Value(
         }
     }
 
-    private final Set<String> validCoordinatesIds = new HashSet<>();
+    private final Set<String> validCoordinatesIds = ConcurrentHashMap.newKeySet();
 
-    private final Set<String> validProfileIds = new HashSet<>();
+    private final Set<String> validProfileIds = ConcurrentHashMap.newKeySet();
 
     @Inject
     public DefaultModelValidator() {}
@@ -1496,7 +1497,7 @@ private boolean validateCoordinatesId(
             String id,
             String sourceHint,
             InputLocationTracker tracker) {
-        if (validCoordinatesIds.contains(id)) {
+        if (id != null && validCoordinatesIds.contains(id)) {
             return true;
         }
         if (!validateStringNotEmpty(prefix, fieldName, problems, severity, version, id, sourceHint, tracker)) {

diff --git a/...ore/src/main/java/org/apache/maven/plugin/internal/DefaultPluginDependenciesResolver.java b/...ore/src/main/java/org/apache/maven/plugin/internal/DefaultPluginDependenciesResolver.java
@@ -134,17 +134,15 @@ public Artifact resolve(Plugin plugin, List<RemoteRepository> repositories, Repo
                 pluginArtifact = pluginArtifact.setProperties(props);
             }
         } catch (ArtifactDescriptorException e) {
-            throw new PluginResolutionException(
-                    plugin, e.getResult().getExceptions(), logger.isDebugEnabled() ? e : null);
+            throw new PluginResolutionException(plugin, e.getResult().getExceptions(), e);
         }
 
         try {
             ArtifactRequest request = new ArtifactRequest(pluginArtifact, repositories, REPOSITORY_CONTEXT);
             request.setTrace(trace);
             pluginArtifact = repoSystem.resolveArtifact(session, request).getArtifact();
         } catch (ArtifactResolutionException e) {
-            throw new PluginResolutionException(
-                    plugin, e.getResult().getExceptions(), logger.isDebugEnabled() ? e : null);
+            throw new PluginResolutionException(plugin, e.getResult().getExceptions(), e);
         }
 
         return pluginArtifact;
@@ -233,16 +231,15 @@ private DependencyResult resolveInternal(
             depRequest.setRoot(node);
             return repoSystem.resolveDependencies(session, depRequest);
         } catch (DependencyCollectionException e) {
-            throw new PluginResolutionException(
-                    plugin, e.getResult().getExceptions(), logger.isDebugEnabled() ? e : null);
+            throw new PluginResolutionException(plugin, e.getResult().getExceptions(), e);
         } catch (DependencyResolutionException e) {
             List<Exception> exceptions = Stream.concat(
                             e.getResult().getCollectExceptions().stream(),
                             e.getResult().getArtifactResults().stream()
                                     .filter(r -> !r.isResolved())
                                     .flatMap(r -> r.getExceptions().stream()))
                     .collect(Collectors.toList());
-            throw new PluginResolutionException(plugin, exceptions, logger.isDebugEnabled() ? e : null);
+            throw new PluginResolutionException(plugin, exceptions, e);
         }
     }
 }
diff --git a/maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java b/maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java
@@ -160,9 +160,7 @@ public DependencyResolutionResult resolve(DependencyResolutionRequest request)
             result.setCollectionErrors(e.getResult().getExceptions());
 
             throw new DependencyResolutionException(
-                    result,
-                    "Could not collect dependencies for project " + project.getId(),
-                    logger.isDebugEnabled() ? e : null);
+                    result, "Could not collect dependencies for project " + project.getId(), e);
         }
 
         depRequest.setRoot(node);
@@ -192,9 +190,7 @@ public DependencyResolutionResult resolve(DependencyResolutionRequest request)
             process(result, e.getResult().getArtifactResults());
 
             throw new DependencyResolutionException(
-                    result,
-                    "Could not resolve dependencies for project " + project.getId(),
-                    logger.isDebugEnabled() ? e : null);
+                    result, "Could not resolve dependencies for project " + project.getId(), e);
         }
 
         return result;