-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Instead of only including causes, suppressed exceptions are now included as well. A similar indentation strategy as in `Throwable.printStackTrace` is used. Back ported 56674cd --- https://issues.apache.org/jira/browse/MNG-7778
- Loading branch information
Showing
2 changed files
with
89 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
maven-slf4j-provider/src/test/java/org/slf4j/impl/MavenSimpleLoggerTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package org.slf4j.impl; | ||
|
||
import java.io.ByteArrayOutputStream; | ||
import java.io.PrintStream; | ||
import java.util.Arrays; | ||
import java.util.List; | ||
import java.util.NoSuchElementException; | ||
|
||
import org.junit.Test; | ||
|
||
import static java.nio.charset.StandardCharsets.UTF_8; | ||
import static org.hamcrest.MatcherAssert.assertThat; | ||
import static org.hamcrest.Matchers.stringContainsInOrder; | ||
|
||
public class MavenSimpleLoggerTest { | ||
|
||
@Test | ||
public void includesCauseAndSuppressedExceptionsWhenWritingThrowables() throws Exception { | ||
Exception causeOfSuppressed = new NoSuchElementException("cause of suppressed"); | ||
Exception suppressed = new IllegalStateException("suppressed", causeOfSuppressed); | ||
suppressed.addSuppressed(new IllegalArgumentException( | ||
"suppressed suppressed", new ArrayIndexOutOfBoundsException("suppressed suppressed cause"))); | ||
Exception cause = new IllegalArgumentException("cause"); | ||
cause.addSuppressed(suppressed); | ||
Exception throwable = new RuntimeException("top-level", cause); | ||
|
||
ByteArrayOutputStream output = new ByteArrayOutputStream(); | ||
|
||
new MavenSimpleLogger("logger").writeThrowable(throwable, new PrintStream(output)); | ||
|
||
String actual = output.toString(UTF_8.name()); | ||
|
||
List<String> expectedLines = Arrays.asList( | ||
"java.lang.RuntimeException: top-level", | ||
"Caused by: java.lang.IllegalArgumentException: cause", | ||
" Suppressed: java.lang.IllegalStateException: suppressed", | ||
" Suppressed: java.lang.IllegalArgumentException: suppressed suppressed", | ||
" Caused by: java.lang.ArrayIndexOutOfBoundsException: suppressed suppressed cause", | ||
" Caused by: java.util.NoSuchElementException: cause of suppressed"); | ||
|
||
assertThat(actual, stringContainsInOrder(expectedLines)); | ||
} | ||
} |
c2331d3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍