Skip to content

Commit

Permalink
[MNG-6196] removed remaining Monkey patching, not really necessary
Browse files Browse the repository at this point in the history
done after Emmanuel Bourg #118 PR idea
  • Loading branch information
hboutemy committed May 21, 2017
1 parent 75b23eb commit c2a8787
Show file tree
Hide file tree
Showing 3 changed files with 91 additions and 54 deletions.
20 changes: 2 additions & 18 deletions maven-slf4j-provider/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ under the License.

<name>Maven SLF4J Simple Provider</name>
<description>
Maven SLF4J provider based on SLF4J's simple provider, monkey-patched to support Maven styled colors
Maven SLF4J provider based on SLF4J's simple provider, extended to support Maven styled colors
for levels and stacktraces rendering.
</description>

Expand Down Expand Up @@ -63,6 +63,7 @@ under the License.
<overWrite>false</overWrite>
<outputDirectory>${project.build.directory}/generated-sources/slf4j-simple</outputDirectory>
<includes>org/slf4j/impl/*.java</includes>
<excludes>org/slf4j/impl/StaticLoggerBinder*</excludes>
</artifactItem>
</artifactItems>
</configuration>
Expand Down Expand Up @@ -94,23 +95,6 @@ under the License.
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.codehaus.gmaven</groupId>
<artifactId>groovy-maven-plugin</artifactId>
<version>2.0</version>
<executions>
<execution>
<id>patch-slf4j-simple</id>
<phase>process-sources</phase>
<goals>
<goal>execute</goal>
</goals>
<configuration>
<source>${project.basedir}/src/main/script/patch-slf4j-simple.groovy</source>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
package org.slf4j.impl;

/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import org.slf4j.ILoggerFactory;
import org.slf4j.spi.LoggerFactoryBinder;

/**
* SLF4J LoggerFactoryBinder implementation using MavenSimpleLogger.
* This class is part of the required classes used to specify an
* SLF4J logger provider implementation.
*
* @since 3.5.1
*/
public final class StaticLoggerBinder
implements LoggerFactoryBinder
{
/**
* Declare the version of the SLF4J API this implementation is compiled
* against. The value of this field is usually modified with each release.
*/
// to avoid constant folding by the compiler, this field must *not* be final
@SuppressWarnings( { "checkstyle:staticvariablename", "checkstyle:visibilitymodifier" } )
public static String REQUESTED_API_VERSION = "1.7.25"; // !final

private static final String LOGGER_FACTORY_CLASS_STR = MavenSimpleLoggerFactory.class.getName();

/**
* The unique instance of this class.
*/
private static final StaticLoggerBinder SINGLETON = new StaticLoggerBinder();

/**
* The ILoggerFactory instance returned by the {@link #getLoggerFactory}
* method should always be the same object
*/
private final ILoggerFactory loggerFactory;

/**
* Private constructor to prevent instantiation
*/
private StaticLoggerBinder()
{
loggerFactory = new MavenSimpleLoggerFactory();
}

/**
* Returns the singleton of this class.
*/
public static StaticLoggerBinder getSingleton()
{
return SINGLETON;
}

/**
* Returns the factory.
*/
@Override
public ILoggerFactory getLoggerFactory()
{
return loggerFactory;
}

/**
* Returns the class name.
*/
@Override
public String getLoggerFactoryClassStr()
{
return LOGGER_FACTORY_CLASS_STR;
}
}
36 changes: 0 additions & 36 deletions maven-slf4j-provider/src/main/script/patch-slf4j-simple.groovy

This file was deleted.

0 comments on commit c2a8787

Please sign in to comment.