[MNG-8469] Regression: Maven 4-rc-2 fails to build Apache Shiro (Karaf issue)

[jira-importer]

Lenny Primak opened MNG-8469 and commented

During the build of Apache Shiro, the following errors are encountered.

This is a regression from rc-1

The build succeeds, but the functionality is broken. You will need to scroll up to see the errors.

[INFO] ------------------< org.apache.shiro:shiro-features >-------------------
[INFO] Building Apache Shiro :: Support :: Karaf Features 2.0.0-SNAPSHOT [30/62]
[INFO]   from support/features/pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[WARNING] The POM for org.apache.karaf.features:framework:kar:4.4.6 is invalid, transitive dependencies (if any) will not be available: 27 problems were encountered while building the effective model for org.apache.karaf.features:framework:pom:4.4.6
    - [ERROR] recursive variable reference: scm.connection
    - [ERROR] recursive variable reference: scm.developerConnection
    - [ERROR] recursive variable reference: scm.url
    - [ERROR] recursive variable reference: scm.connection
    - [ERROR] recursive variable reference: scm.developerConnection
    - [ERROR] recursive variable reference: scm.url
    - [ERROR] recursive variable reference: scm.connection
    - [ERROR] recursive variable reference: scm.developerConnection
    - [ERROR] recursive variable reference: scm.url
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.features:base:jar is missing. @ line 54, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf:org.apache.karaf.main:jar is missing. @ line 59, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf:org.apache.karaf.client:jar is missing. @ line 64, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.jaas:org.apache.karaf.jaas.boot:jar is missing. @ line 69, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.diagnostic:org.apache.karaf.diagnostic.boot:jar is missing. @ line 74, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.config:org.apache.karaf.config.core:jar is missing. @ line 79, column 9
    - [ERROR] 'dependencies.dependency.version' for org.eclipse.platform:org.eclipse.osgi:jar is missing. @ line 83, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.felix:org.apache.felix.framework:jar is missing. @ line 88, column 9
    - [ERROR] 'dependencies.dependency.version' for org.jline:jline:jar is missing. @ line 95, column 9
    - [ERROR] 'dependencies.dependency.version' for org.ops4j.pax.logging:pax-logging-api:jar is missing. @ line 101, column 9
    - [ERROR] 'dependencies.dependency.version' for org.ops4j.pax.logging:pax-logging-log4j2:jar is missing. @ line 105, column 9
    - [ERROR] 'dependencies.dependency.version' for org.ops4j.pax.logging:pax-logging-logback:jar is missing. @ line 109, column 9
    - [ERROR] 'dependencies.dependency.version' for org.ops4j.pax.url:pax-url-aether:jar is missing. @ line 113, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.felix:org.apache.felix.fileinstall:jar is missing. @ line 168, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.felix:org.apache.felix.configadmin:jar is missing. @ line 172, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.felix:org.apache.felix.configadmin.plugin.interpolation:jar is missing. @ line 176, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.features:org.apache.karaf.features.extension:jar is missing. @ line 181, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.features:org.apache.karaf.features.core:jar is missing. @ line 185, column 9 

---

Affects: 4.0.0-rc-2

Remote Links:

• GitHub Pull Request #2011
  

Backported to: 4.0.0-rc-3

[jira-importer]

Tamas Cservenak commented

This is a blocker, clearly is broken in maven master:

[cstamas@angeleyes ~]$ mvn -V toolbox:gav-tree -Dgav=org.apache.karaf.features:framework:pom:4.4.6 
Apache Maven 4.0.0-rc-3-SNAPSHOT (ee5741d8cddc01f9e2fc18e8fee3b1ed6155d6dd)
Maven home: /home/cstamas/Tools/maven/apache-maven-4.0.0-rc-3-SNAPSHOT
Java version: 21.0.5, vendor: Eclipse Adoptium, runtime: /home/cstamas/.sdkman/candidates/java/21.0.5-tem
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.12.5-200.fc41.x86_64", arch: "amd64", family: "unix"
[INFO] 
[INFO] 1 problem was encountered while building the effective settings (use -e to see details)
[INFO] 
[INFO] Scanning for projects...
[INFO] 
[INFO] -------------------------------------------< org.apache.maven:standalone-pom >--------------------------------------------
[INFO] Building Maven Stub Project (No POM) 1
[INFO] ---------------------------------------------------------[ pom ]----------------------------------------------------------
[INFO] 
[INFO] --- toolbox:0.6.1:gav-tree (default-cli) @ standalone-pom ---
[WARNING] The POM for org.apache.karaf.features:framework:pom:4.4.6 is invalid, transitive dependencies (if any) will not be available: 21 problems were encountered while building the effective model for org.apache.karaf.features:framework:pom:4.4.6
    - [ERROR] recursive variable reference: scm.connection
    - [ERROR] recursive variable reference: scm.developerConnection
    - [ERROR] recursive variable reference: scm.url
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.features:base:jar is missing. @ line 54, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf:org.apache.karaf.main:jar is missing. @ line 59, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf:org.apache.karaf.client:jar is missing. @ line 64, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.jaas:org.apache.karaf.jaas.boot:jar is missing. @ line 69, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.diagnostic:org.apache.karaf.diagnostic.boot:jar is missing. @ line 74, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.config:org.apache.karaf.config.core:jar is missing. @ line 79, column 9
    - [ERROR] 'dependencies.dependency.version' for org.eclipse.platform:org.eclipse.osgi:jar is missing. @ line 83, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.felix:org.apache.felix.framework:jar is missing. @ line 88, column 9
    - [ERROR] 'dependencies.dependency.version' for org.jline:jline:jar is missing. @ line 95, column 9
    - [ERROR] 'dependencies.dependency.version' for org.ops4j.pax.logging:pax-logging-api:jar is missing. @ line 101, column 9
    - [ERROR] 'dependencies.dependency.version' for org.ops4j.pax.logging:pax-logging-log4j2:jar is missing. @ line 105, column 9
    - [ERROR] 'dependencies.dependency.version' for org.ops4j.pax.logging:pax-logging-logback:jar is missing. @ line 109, column 9
    - [ERROR] 'dependencies.dependency.version' for org.ops4j.pax.url:pax-url-aether:jar is missing. @ line 113, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.felix:org.apache.felix.fileinstall:jar is missing. @ line 168, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.felix:org.apache.felix.configadmin:jar is missing. @ line 172, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.felix:org.apache.felix.configadmin.plugin.interpolation:jar is missing. @ line 176, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.features:org.apache.karaf.features.extension:jar is missing. @ line 181, column 9
    - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.features:org.apache.karaf.features.core:jar is missing. @ line 185, column 9
[INFO] org.apache.karaf.features:framework:pom:4.4.6
[INFO] --------------------------------------------------------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] --------------------------------------------------------------------------------------------------------------------------
[INFO] Total time:  0.306 s
[INFO] Finished at: 2024-12-23T17:23:47+01:00
[INFO] --------------------------------------------------------------------------------------------------------------------------
[cstamas@angeleyes ~]$ sdk use maven 3.9.9 

Using maven version 3.9.9 in this shell.
[cstamas@angeleyes ~]$ mvn -V toolbox:gav-tree -Dgav=org.apache.karaf.features:framework:pom:4.4.6 
Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
Maven home: /home/cstamas/.sdkman/candidates/maven/3.9.9
Java version: 21.0.5, vendor: Eclipse Adoptium, runtime: /home/cstamas/.sdkman/candidates/java/21.0.5-tem
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.12.5-200.fc41.x86_64", arch: "amd64", family: "unix"
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------< org.apache.maven:standalone-pom >-------------------
[INFO] Building Maven Stub Project (No POM) 1
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- toolbox:0.6.1:gav-tree (default-cli) @ standalone-pom ---
Downloading from central: https://repo.maven.apache.org/maven2/org/slf4j/slf4j-api/2.0.12/slf4j-api-2.0.12.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/slf4j/slf4j-api/2.0.12/slf4j-api-2.0.12.pom (2.8 kB at 14 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/slf4j/slf4j-parent/2.0.12/slf4j-parent-2.0.12.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/slf4j/slf4j-parent/2.0.12/slf4j-parent-2.0.12.pom (13 kB at 382 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/slf4j/slf4j-bom/2.0.12/slf4j-bom-2.0.12.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/slf4j/slf4j-bom/2.0.12/slf4j-bom-2.0.12.pom (7.3 kB at 319 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/slf4j/jcl-over-slf4j/2.0.12/jcl-over-slf4j-2.0.12.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/slf4j/jcl-over-slf4j/2.0.12/jcl-over-slf4j-2.0.12.pom (1.7 kB at 75 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/osgi/osgi.core/8.0.0/osgi.core-8.0.0.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/osgi/osgi.core/8.0.0/osgi.core-8.0.0.pom (1.6 kB at 81 kB/s)
[INFO] org.apache.karaf.features:framework:pom:4.4.6
[INFO] ├─org.apache.karaf.features:base:jar:4.4.6 [runtime]
[INFO] │ ├─jakarta.xml.bind:jakarta.xml.bind-api:jar:2.3.3 [compile] (exclusions applied: 1)
[INFO] │ ├─javax.annotation:javax.annotation-api:jar:1.3.2 [runtime]
[INFO] │ ├─org.apache.servicemix.specs:org.apache.servicemix.specs.activation-api-1.2.1:jar:1.2.1_3 [runtime]
[INFO] │ ├─org.glassfish.jaxb:jaxb-runtime:jar:2.3.8 [compile]
[INFO] │ │ ╰─com.sun.activation:jakarta.activation:jar:1.2.2 [runtime]
[INFO] │ ├─org.glassfish.jaxb:txw2:jar:2.3.8 [compile]
[INFO] │ ├─com.sun.istack:istack-commons-runtime:jar:3.0.12 [compile]
[INFO] │ ├─org.apache.karaf.specs:org.apache.karaf.specs.locator:jar:4.4.6 [runtime]
[INFO] │ ├─org.apache.karaf.specs:org.apache.karaf.specs.java.xml:jar:4.4.6 [runtime]
[INFO] │ │ ├─org.apache.geronimo.specs:geronimo-stax-api_1.2_spec:jar:1.2 [runtime]
[INFO] │ │ ╰─xml-apis:xml-apis:jar:1.4.01 [runtime]
[INFO] │ ├─org.apache.karaf.specs:org.apache.karaf.specs.java.xml.ws:jar:4.4.6 [runtime]
[INFO] │ │ ├─org.apache.geronimo.specs:geronimo-saaj_1.3_spec:jar:1.1 [runtime]
[INFO] │ │ ╰─org.apache.geronimo.specs:geronimo-jaxws_2.2_spec:jar:1.2 [runtime]
[INFO] │ ╰─org.apache.karaf.specs:org.apache.karaf.specs.activator:jar:4.4.6 [runtime]
[INFO] ├─org.apache.karaf:org.apache.karaf.main:jar:4.4.6 [runtime]
[INFO] │ ├─org.apache.karaf:org.apache.karaf.util:jar:4.4.6 [compile]
[INFO] │ │ ╰─org.apache.felix:org.apache.felix.utils:jar:1.11.8 [compile] (exclusions applied: 2)
[INFO] │ ├─net.java.dev.jna:jna:jar:5.14.0 [runtime]
[INFO] │ ╰─net.java.dev.jna:jna-platform:jar:5.14.0 [runtime]
[INFO] ├─org.apache.karaf:org.apache.karaf.client:jar:4.4.6 [runtime]
[INFO] │ ├─org.apache.sshd:sshd-osgi:jar:2.12.1 [runtime]
[INFO] │ │ ╰─org.slf4j:jcl-over-slf4j:jar:2.0.12 [runtime] (version managed from 1.7.32)
[INFO] │ ╰─org.slf4j:slf4j-api:jar:2.0.12 [compile]
[INFO] ├─org.apache.karaf.jaas:org.apache.karaf.jaas.boot:jar:4.4.6 [runtime]
[INFO] ├─org.apache.karaf.diagnostic:org.apache.karaf.diagnostic.boot:jar:4.4.6 [runtime]
[INFO] ├─org.apache.karaf.config:org.apache.karaf.config.core:jar:4.4.6 [compile]
[INFO] │ ├─org.apache.felix:org.apache.felix.cm.json:jar:1.0.6 [compile]
[INFO] │ ├─org.apache.sling:org.apache.sling.commons.johnzon:jar:1.2.16 [compile]
[INFO] │ ╰─org.apache.geronimo.specs:geronimo-json_1.1_spec:jar:1.5 [compile]
[INFO] ├─org.eclipse.platform:org.eclipse.osgi:jar:3.18.0 [runtime]
[INFO] ├─org.apache.felix:org.apache.felix.framework:jar:7.0.5 [runtime] (exclusions applied: 1)
[INFO] │ ╰─org.codehaus.mojo:animal-sniffer-annotations:jar:1.9 [runtime]
[INFO] ├─org.jline:jline:jar:3.21.0 [compile]
[INFO] ├─org.ops4j.pax.logging:pax-logging-api:jar:2.2.7 [compile]
[INFO] │ ├─org.osgi:osgi.core:jar:8.0.0 [provided] (version managed from 7.0.0) (scope managed from compile)
[INFO] │ ╰─org.osgi:osgi.cmpn:jar:7.0.0 [compile]
[INFO] ├─org.ops4j.pax.logging:pax-logging-log4j2:jar:2.2.7 [compile]
[INFO] │ ╰─org.osgi:osgi.annotation:jar:7.0.0 [compile]
[INFO] ├─org.ops4j.pax.logging:pax-logging-logback:jar:2.2.7 [compile]
[INFO] │ ├─ch.qos.logback:logback-core:jar:1.3.14 [compile]
[INFO] │ ├─ch.qos.logback:logback-classic:jar:1.3.14 [compile]
[INFO] │ ├─ch.qos.logback.contrib:logback-jackson:jar:0.1.5 [compile]
[INFO] │ ├─ch.qos.logback.contrib:logback-json-core:jar:0.1.5 [compile]
[INFO] │ ╰─ch.qos.logback.contrib:logback-json-classic:jar:0.1.5 [compile]
[INFO] ├─org.ops4j.pax.url:pax-url-aether:jar:2.6.14 [compile] (exclusions managed from [org.ops4j.pax.url:pax-url-commons:*:*, org.slf4j:slf4j-api:*:*, org.slf4j:jcl-over-slf4j:*:*, org.eclipse.aether:aether-api:*:*, org.eclipse.aether:aether-spi:*:*, org.eclipse.aether:aether-util:*:*, org.eclipse.aether:aether-impl:*:*, org.eclipse.aether:aether-connector-basic:*:*, org.eclipse.aether:aether-transport-wagon:*:*, org.apache.maven:maven-settings-builder:*:*, org.sonatype.plexus:plexus-sec-dispatcher:*:*, org.sonatype.plexus:plexus-cipher:*:*])
[INFO] ├─org.apache.felix:org.apache.felix.fileinstall:jar:3.7.4 [compile] (exclusions applied: 2)
[INFO] ├─org.apache.felix:org.apache.felix.configadmin:jar:1.9.26 [compile]
[INFO] ├─org.apache.felix:org.apache.felix.configadmin.plugin.interpolation:jar:1.2.8 [compile]
[INFO] ├─org.apache.karaf.features:org.apache.karaf.features.extension:jar:4.4.6 [compile]
[INFO] ╰─org.apache.karaf.features:org.apache.karaf.features.core:jar:4.4.6 [compile]
[INFO]   ├─org.ops4j.base:ops4j-base-util-property:jar:1.5.1 [compile]
[INFO]   ├─org.ops4j.base:ops4j-base-util-collections:jar:1.5.1 [compile]
[INFO]   │ ╰─org.ops4j.base:ops4j-base-lang:jar:1.5.1 [compile]
[INFO]   ├─org.ops4j.pax.swissbox:pax-swissbox-property:jar:1.8.5 [compile]
[INFO]   ├─com.fasterxml.jackson.core:jackson-databind:jar:2.14.1 [compile]
[INFO]   │ ├─com.fasterxml.jackson.core:jackson-annotations:jar:2.14.1 [compile]
[INFO]   │ ╰─com.fasterxml.jackson.core:jackson-core:jar:2.14.1 [compile]
[INFO]   ╰─javax.activation:activation:jar:1.1.1 [compile]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.794 s
[INFO] Finished at: 2024-12-23T17:23:57+01:00
[INFO] ------------------------------------------------------------------------
[cstamas@angeleyes ~]$ 

[jira-importer]

Tamas Cservenak commented

Problem is "un-prefixed" model reflection that kicks in before model properties (where property is defined).
See https://repo.maven.apache.org/maven2/org/apache/karaf/karaf/4.4.6/karaf-4.4.6.pom

Problem is this:

<scm>
  <connection>${scm.connection}</connection>
  <developerConnection>${scm.developerConnection}</developerConnection>
  <url>${scm.url}</url>
  <tag>karaf-4.4.6</tag>
</scm>

And the scm.connection goes to model instead a property (that does exists).

[jira-importer]

Tamas Cservenak commented

In maven3 order of sources are:

• basedir
• basedirUri
• buildTime
• prefixed rootDirectory
• projectPrefix
• user props
• model props
• system props
• env
• prefixlessObject

We need to restore this