Add skipMavenRc to ExecutorRequest and use it in ITs #10925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ITs should be isolated from the executing system, so: - skip mavenrc in forked mode - exclude MAVEN_ARGS and MAVEN_OPTS from test environments
slawekjaranowski
force-pushed
the
skip-mven-rc
branch
from
f73f3dc to
018ba1a
Compare
gnodet
approved these changes
Jul 17, 2025
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
LGTM, two minor suggestions
impl/maven-executor/src/main/java/org/apache/maven/api/cli/ExecutorRequest.java
Outdated
Show resolved
Hide resolved
impl/maven-executor/src/main/java/org/apache/maven/api/cli/ExecutorRequest.java
Show resolved
Hide resolved
cstamas
approved these changes
Jul 17, 2025
|
@slawekjaranowski Please assign appropriate label to PR according to the type of change. |
slawekjaranowski
added a commit
to slawekjaranowski/maven
that referenced
this pull request
Jul 18, 2025
* Add skipMavenRc to ExecutorRequest and use it in ITs ITs should be isolated from the executing system, so: - skip mavenrc in forked mode - exclude MAVEN_ARGS and MAVEN_OPTS from test environments (cherry picked from commit e2ad3e6)
slawekjaranowski
added a commit
that referenced
this pull request
Jul 19, 2025
* Add skipMavenRc to ExecutorRequest and use it in ITs ITs should be isolated from the executing system, so: - skip mavenrc in forked mode - exclude MAVEN_ARGS and MAVEN_OPTS from test environments (cherry picked from commit e2ad3e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITs should be isolated from the executing system, so: