Uninterpolated repositories from parent POMs during model building #11037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On parent loading, the repositories were interpolated okay, but there was a problem that parent properties were not considered in interpolation. Fixes apache#11021
gnodet
reviewed
Aug 11, 2025
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
LGTM, a test would be nice, but no big deal.
gnodet
approved these changes
Aug 11, 2025
Member
Author
|
Add UT, originally authored on master (to verify it fails) and passes ok in PR |
This was referenced Aug 11, 2025
Closed
Member
Author
|
Received reproducer: https://github.com/lprimak/apps w/ master and w/ this PR: https://gist.github.com/cstamas/9deaaedb9063c3500d763b0d5601283d |
cstamas
added a commit
to cstamas/maven
that referenced
this pull request
Aug 12, 2025
…pache#11037) On parent loading, the repositories were interpolated okay, but there was a problem that parent own properties were not considered in interpolation (of own repositories). Fixes apache#11021
cstamas
added a commit
that referenced
this pull request
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On parent loading, the repositories were interpolated okay, but there was a problem that parent own properties were not considered in interpolation (of own repositories).
Fixes #11021