Inject core services directly into Maven 4 Mojos; add opt-in real-session testing (#11055)

[gnodet]

Summary

• Ensure all core services can be injected directly into Maven 4 Mojos via @Inject, aligning field injection with Session#getService behavior
• Make it straightforward to run mojo tests against a real Maven Session when needed
• Closes Maven 4: Obtaining services appears to be inconsistent between unit tests and production. #11055

Why

• In some cases, field injection via @Inject failed for services that were retrievable via Session#getService, causing an inconsistency for Maven 4 plugins
• Plugin authors and core developers need an easy way to run tests with a real session when mocks are not sufficient (e.g., for settings decryption, toolchains, repository wiring)

What changed (highlights)

• DI/service exposure
  • Seed all available V4 services into the plugin execution scope so @Inject works for Mojos
  • Expose core services comprehensively to the DI container, and unify discovery across Sisu/Guice bridge and internal injector
• Testing support
  • New @MojoTest(realSession = true) flag to obtain a real session (via ApiRunner) in mojo tests when requested
  • Allow tests to override the session by providing a @provides Session bean (takes precedence over the flag)
• Integration tests
  • New IT reproducing the problem and validating that @Inject on Mojos works for representative core services

Key implementation details

• Plugin execution wiring
  • DefaultBuildPluginManager: seed all Session V4 services into the plugin scope for Maven 4 Mojos
  • DefaultMavenPluginManager: bind suppliers for all services into the injector before creating the Mojo instance
• Service discovery and DI improvements
  • InternalSession + AbstractSession: new getAllServices() returning a map of service interfaces to suppliers; services discovered lazily from the injector to avoid eager creation
  • SisuDiBridgeModule: expose getAllBindings(Class) and improve type-to-key resolution to include Named bindings when no qualifier is present
  • DI injector: add bindSupplier(...) and Binding.toSupplier(...) facilities, plus helper to enumerate bindings
  • DefaultArtifactManager and DefaultProjectManager: explicitly @typed({X.class, Service.class}) so they are exposed as Service implementations discoverable by getAllServices()
• Session-scoped proxies and @typed semantics
  • SessionScope: when @typed has an empty value, only the class’s direct interfaces are included (not super-interfaces), per project convention; clearer error if @typed is missing
  • Unit tests added to pin this behavior
• Testing utilities
  • MojoExtension/@MojoTest: optional real session via ApiRunner.createSession() when realSession = true; if creation fails and realSession is true, abort the test with context
  • New SecDispatcherProvider that offers a minimal surface to decrypt settings in tests
• CI workflow
  • GitHub Actions: use mvn install (instead of verify) in the main job to ensure locally installed artifacts are available to ITs

Backward compatibility and risks

• Public Maven 4 plugin developer experience improves: @Inject for services in Mojos now matches Session#getService availability
• InternalSession adds a new method (getAllServices); this is internal to Maven’s impl module and should not affect plugin API compatibility
• @typed behavior is clarified and tested; existing uses that relied on implicit super-interface inclusion may need to specify explicit interfaces in @typed
• Minimal CI change from verify to install; builds remain fully validated and provide locally installed artifacts for ITs

Tests

• Unit tests
  • impl/maven-impl: SessionScopeTest for @typed behavior and session-scoped proxies
  • impl/maven-testing: MojoRealSessionTest validates default mock session, real session opt-in, and provider override precedence
• Integration tests
  • its/core-it-suite: MavenITgh11055DIServiceInjectionTest and resources under Maven 4: Obtaining services appears to be inconsistent between unit tests and production. #11055-di-service-injection validate @Inject coverage for core services in a real Maven flow

How to use (examples)

• Inject services directly in Maven 4 Mojos:

@Inject
protected ArtifactManager artifactManager;

@Inject
protected DependencyResolver dependencyResolver;

• Opt into a real session in a mojo test:
  • Annotate your test class with @MojoTest(realSession = true)
  • Or provide your own @provides @singleton Session to override the default/mock behavior

Notes for reviewers

• The change is intentionally scoped to Maven 4 Mojos (mojoDescriptor.isV4Api()). Legacy Mojos are not affected
• DI improvements are conservative: suppliers avoid eager creation; the Sisu/Guice bridge only contributes Plexus beans marked accordingly
• The new testing affordances help plugin authors (and core) validate realistic scenarios (e.g., settings decryption) without introducing compile-time cycles

Follow-ups

• Optional: add short developer documentation about @MojoTest(realSession = true) and clarifying @typed behavior in SessionScope
• Optional: add a brief release note for plugin developers about service injection in Maven 4 Mojos

[gnodet]

💚 All backports created successfully

Status	Branch	Result
✅	maven-4.0.x

Questions ?

Please refer to the Backport tool documentation