Fix exception caused by duplicate dependencies in consumer pom #11283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstamas
reviewed
Oct 16, 2025
| if (managementKey == null) { | ||
| managementKey = (getGroupId() + ":" + getArtifactId() + ":" + getType() + (getClassifier() != null ? ":" + getClassifier() : "")).intern(); | ||
| managementKey = (getGroupId() + ":" + getArtifactId() + ":" + getType() | ||
| + (getClassifier() != null && !getClassifier().isEmpty() ? ":" + getClassifier() : "")).intern(); |
Member
There was a problem hiding this comment.
Perso I prefer isBlank() since 11+
Contributor
Author
There was a problem hiding this comment.
Not sure though... All the checks are done with isEmpty() in the code, so introducing a isBlank() at one point may lead to inconsistencies.
Member
There was a problem hiding this comment.
sure, I agree, I just said "my 5 cents"
Contributor
Author
There was a problem hiding this comment.
More checks:
There's a single check for isBlank and I think it's wrong at this point.
cstamas
approved these changes
Oct 16, 2025
|
Thanks for fast turnaround @gnodet |
|
I tested a build from this branch and now build passes :) |
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 16, 2025
…e#11283) Fixes apache#11280 (cherry picked from commit 1a02597)
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gnodet
added a commit
that referenced
this pull request
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11280