Skip to content

Fix plugin prefix resolution when metadata is not available from repository #11290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slawekjaranowski merged 1 commit into from
Oct 17, 2025
Merged

Fix plugin prefix resolution when metadata is not available from repository #11290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 54 additions & 18 deletions ...re/src/main/java/org/apache/maven/plugin/prefix/internal/DefaultPluginPrefixResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,21 @@
import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashSet;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.stream.Collectors;
import java.util.stream.Stream;

import org.apache.maven.artifact.repository.metadata.Metadata;
import org.apache.maven.artifact.repository.metadata.io.MetadataReader;
import org.apache.maven.model.Build;
import org.apache.maven.model.Model;
import org.apache.maven.model.Plugin;
import org.apache.maven.model.PluginManagement;
import org.apache.maven.plugin.BuildPluginManager;
import org.apache.maven.plugin.descriptor.PluginDescriptor;
import org.apache.maven.plugin.prefix.NoPluginFoundForPrefixException;
import org.apache.maven.plugin.prefix.PluginPrefixRequest;
import org.apache.maven.plugin.prefix.PluginPrefixResolver;
Expand Down Expand Up @@ -64,6 +71,9 @@ public class DefaultPluginPrefixResolver implements PluginPrefixResolver {
@Requirement
private Logger logger;

@Requirement
private BuildPluginManager pluginManager;

@Requirement
private RepositorySystem repositorySystem;

Expand All @@ -73,33 +83,37 @@ public class DefaultPluginPrefixResolver implements PluginPrefixResolver {
public PluginPrefixResult resolve(PluginPrefixRequest request) throws NoPluginFoundForPrefixException {
logger.debug("Resolving plugin prefix " + request.getPrefix() + " from " + request.getPluginGroups());

Model pom = request.getPom();
Build build = pom != null ? pom.getBuild() : null;
PluginManagement management = build != null ? build.getPluginManagement() : null;

// map of groupId -> Set(artifactId) plugin candidates:
// if value is null, keys are coming from settings, and no artifactId filtering is applied
// if value is non-null: we allow only plugins that have enlisted artifactId only
// ---
// end game is: settings enlisted groupIds are obeying order and are "free for all" (artifactId)
// while POM enlisted plugins coming from non-enlisted settings groupIds (ie conflict of prefixes)
// will prevail/win.
LinkedHashMap<String, Set<String>> candidates = new LinkedHashMap<>();
if (request.getPom() != null) {
if (request.getPom().getBuild() != null) {
request.getPom().getBuild().getPlugins().stream()
.filter(p -> !request.getPluginGroups().contains(p.getGroupId()))
.forEach(p -> candidates
.computeIfAbsent(p.getGroupId(), g -> new HashSet<>())
.add(p.getArtifactId()));
if (request.getPom().getBuild().getPluginManagement() != null) {
request.getPom().getBuild().getPluginManagement().getPlugins().stream()
.filter(p -> !request.getPluginGroups().contains(p.getGroupId()))
.forEach(p -> candidates
.computeIfAbsent(p.getGroupId(), g -> new HashSet<>())
.add(p.getArtifactId()));
}
}
}
LinkedHashMap<String, Set<String>> candidates = Stream.of(build, management)
.flatMap(container -> container != null ? container.getPlugins().stream() : Stream.empty())
.filter(p -> !request.getPluginGroups().contains(p.getGroupId()))
.collect(Collectors.groupingBy(
Plugin::getGroupId,
LinkedHashMap::new,
Collectors.mapping(Plugin::getArtifactId, Collectors.toSet())));
request.getPluginGroups().forEach(g -> candidates.put(g, null));
PluginPrefixResult result = resolveFromRepository(request, candidates);

// If we haven't been able to resolve the plugin from the repository,
// as a last resort, we go through all declared plugins, load them
// one by one, and try to find a matching prefix.
if (result == null && build != null) {
result = resolveFromProject(request, build.getPlugins());
if (result == null && management != null) {
result = resolveFromProject(request, management.getPlugins());
}
}

if (result == null) {
throw new NoPluginFoundForPrefixException(
request.getPrefix(),
Expand All @@ -115,6 +129,28 @@ public PluginPrefixResult resolve(PluginPrefixRequest request) throws NoPluginFo
return result;
}

private PluginPrefixResult resolveFromProject(PluginPrefixRequest request, List<Plugin> plugins) {
for (Plugin plugin : plugins) {
try {
PluginDescriptor pluginDescriptor =
pluginManager.loadPlugin(plugin, request.getRepositories(), request.getRepositorySession());

if (request.getPrefix().equals(pluginDescriptor.getGoalPrefix())) {
return new DefaultPluginPrefixResult(plugin);
}
} catch (Exception e) {
if (logger.isDebugEnabled()) {
logger.warn(
"Failed to retrieve plugin descriptor for " + plugin.getId() + ": " + e.getMessage(), e);
} else {
logger.warn("Failed to retrieve plugin descriptor for " + plugin.getId() + ": " + e.getMessage());
}
}
}

return null;
}

private PluginPrefixResult resolveFromRepository(
PluginPrefixRequest request, LinkedHashMap<String, Set<String>> candidates) {
RequestTrace trace = RequestTrace.newChild(null, request);
Expand Down