Restore compatibility in maven-embedder #11320
Merged
+1,186
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@laeubi will that fix all your compatibility problems ? |
laeubi
approved these changes
Oct 24, 2025
Contributor
laeubi
left a comment
laeubi
left a comment
There was a problem hiding this comment.
This looks good to me thanks!
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
- Created org.apache.maven.cli.internal.extension.model package - Added CoreExtension and CoreExtensions classes (deprecated) - Updated ExtensionResolutionException to return old model type - Added overloaded constructor for compatibility with new API Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
gnodet
force-pushed
the
copilot/fix-missing-code-restoration
branch
from
c525ab3 to
ff3bc7b
Compare
cstamas
approved these changes
Oct 27, 2025
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 27, 2025
* Initial plan * Add missing deprecated constants to MavenCli for backward compatibility Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com> * Add missing extension model classes for backward compatibility - Created org.apache.maven.cli.internal.extension.model package - Added CoreExtension and CoreExtensions classes (deprecated) - Updated ExtensionResolutionException to return old model type - Added overloaded constructor for compatibility with new API Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com> * Add missing xpp3 reader/writer * Do not add @deprecated on constants since the class already is * Add two other missing constants --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com> (cherry picked from commit 9a5fb67)
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gnodet
added a commit
that referenced
this pull request
Oct 27, 2025
* Initial plan * Add missing deprecated constants to MavenCli for backward compatibility * Add missing extension model classes for backward compatibility - Created org.apache.maven.cli.internal.extension.model package - Added CoreExtension and CoreExtensions classes (deprecated) - Updated ExtensionResolutionException to return old model type - Added overloaded constructor for compatibility with new API * Add missing xpp3 reader/writer * Do not add @deprecated on constants since the class already is * Add two other missing constants --------- (cherry picked from commit 9a5fb67) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing deprecated constants and classes for backward compatibility in
maven-embedder.Fixes #11300