Fix [unknown project] messages in error output #11324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
force-pushed
the
fix-unknown-project-issue-11292
branch
from
a886342 to
b5b3203
Compare
cstamas
approved these changes
Oct 27, 2025
Resolves issue apache#11292 where Maven shows '[unknown project]' in error messages when using -e -X flags, particularly in CI environments. The issue occurred because DefaultProjectBuilder was creating DefaultProjectBuildingResult with null project information when ModelBuilderResult.getEffectiveModel() returned null, resulting in empty projectId and causing ProjectBuildingException.createMessage() to display '[unknown project]' as a fallback. This fix extracts project identification from available model data (rawModel or fileModel) when effectiveModel is null, following the same pattern used in ModelBuilderException.getModelId(). Changes: - Added extractProjectId() helper method that falls back to rawModel or fileModel when effectiveModel is null - Modified project building result creation to use extracted projectId and POM file information instead of null values - Maintains backward compatibility: when all models are null, still returns empty string to preserve '[unknown project]' fallback for truly unknown projects This provides better error messages showing meaningful project identification like 'com.example:my-project:jar:1.0.0' even when project building fails, while maintaining existing error handling patterns.
Tests verify the fallback behavior when extracting project identification from ModelBuilderResult: - Falls back to rawModel when effectiveModel is null - Falls back to fileModel when both effectiveModel and rawModel are null - Returns empty string when all models are null These tests ensure the fix for issue apache#11292 works correctly and maintains backward compatibility.
gnodet
force-pushed
the
fix-unknown-project-issue-11292
branch
from
b5b3203 to
4ec38f8
Compare
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 28, 2025
Resolves issue apache#11292 where Maven shows '[unknown project]' in error messages when using -e -X flags, particularly in CI environments. The issue occurred because DefaultProjectBuilder was creating DefaultProjectBuildingResult with null project information when ModelBuilderResult.getEffectiveModel() returned null, resulting in empty projectId and causing ProjectBuildingException.createMessage() to display '[unknown project]' as a fallback. This fix extracts project identification from available model data (rawModel or fileModel) when effectiveModel is null, following the same pattern used in ModelBuilderException.getModelId(). Changes: - Added extractProjectId() helper method that falls back to rawModel or fileModel when effectiveModel is null - Modified project building result creation to use extracted projectId and POM file information instead of null values - Maintains backward compatibility: when all models are null, still returns empty string to preserve '[unknown project]' fallback for truly unknown projects This provides better error messages showing meaningful project identification like 'com.example:my-project:jar:1.0.0' even when project building fails, while maintaining existing error handling patterns. (cherry picked from commit cb5ee55)
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gnodet
added a commit
that referenced
this pull request
Oct 28, 2025
Resolves issue #11292 where Maven shows '[unknown project]' in error messages when using -e -X flags, particularly in CI environments. The issue occurred because DefaultProjectBuilder was creating DefaultProjectBuildingResult with null project information when ModelBuilderResult.getEffectiveModel() returned null, resulting in empty projectId and causing ProjectBuildingException.createMessage() to display '[unknown project]' as a fallback. This fix extracts project identification from available model data (rawModel or fileModel) when effectiveModel is null, following the same pattern used in ModelBuilderException.getModelId(). Changes: - Added extractProjectId() helper method that falls back to rawModel or fileModel when effectiveModel is null - Modified project building result creation to use extracted projectId and POM file information instead of null values - Maintains backward compatibility: when all models are null, still returns empty string to preserve '[unknown project]' fallback for truly unknown projects This provides better error messages showing meaningful project identification like 'com.example:my-project:jar:1.0.0' even when project building fails, while maintaining existing error handling patterns. (cherry picked from commit cb5ee55)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #11292 where Maven shows '[unknown project]' in error messages when using -e -X flags, particularly in CI environments.
Problem
The issue occurred because
DefaultProjectBuilderwas creatingDefaultProjectBuildingResultwith null project information whenModelBuilderResult.getEffectiveModel()returned null, resulting in empty projectId and causingProjectBuildingException.createMessage()to display '[unknown project]' as a fallback.Solution
This fix extracts project identification from available model data (rawModel or fileModel) when effectiveModel is null, following the same pattern used in
ModelBuilderException.getModelId().Changes
extractProjectId()helper method that falls back to rawModel or fileModel when effectiveModel is nullBenefits
Testing
The fix includes unit tests that verify:
Fixes #11292
Pull Request opened by Augment Code with guidance from the PR author