tests(maven#10389): Adding DefaultDependencyResolverResultTest #11410

vijaykriishna · 2025-11-08T00:55:31Z

Title: [https://github.com//issues/10389] tests(maven#10389): Adding DefaultDependencyResolverResultTest

Added unit tests for DefaultDependencyResolverResult
Following this checklist to help us incorporate your
contribution quickly and easily:

Your pull request should address just one issue, without pulling in other changes.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
Run mvn verify to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.

gnodet

Using DefaultType will remove 150 lines of code and will make the test more readable.

gnodet · 2025-11-18T19:52:15Z

impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultDependencyResolverResultTest.java

+        Dependency dep = mock(Dependency.class);
+        when(dep.getGroupId()).thenReturn("g");
+        when(dep.getArtifactId()).thenReturn("a");
+        when(dep.getType()).thenReturn(new org.apache.maven.api.Type() {


It may be easier to use org.apache.maven.impl.resolver.type.DefaultType instead.

It may be easier to use org.apache.maven.impl.resolver.type.DefaultType instead.

Done.

gnodet · 2025-11-18T19:52:52Z

impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultDependencyResolverResultTest.java

+        Dependency dep = mock(Dependency.class);
+        when(dep.getGroupId()).thenReturn("g");
+        when(dep.getArtifactId()).thenReturn("a");
+        when(dep.getType()).thenReturn(new org.apache.maven.api.Type() {


Same...

Done.

gnodet · 2025-11-18T19:53:01Z

impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultDependencyResolverResultTest.java

+        Path p = Files.createTempFile("unres", ".jar");
+
+        // Type returns a known CLASSES and an unknown custom PathType => selectPathType should return empty
+        when(dep.getType()).thenReturn(new org.apache.maven.api.Type() {


Same...

Done.

gnodet · 2025-11-18T19:53:11Z

impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultDependencyResolverResultTest.java

+        Dependency dep = mock(Dependency.class);
+        when(dep.getGroupId()).thenReturn("g3");
+        when(dep.getArtifactId()).thenReturn("a3");
+        when(dep.getType()).thenReturn(new org.apache.maven.api.Type() {


Same...

Done.

gnodet · 2025-11-18T19:53:19Z

impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultDependencyResolverResultTest.java

+        Dependency dep1 = mock(Dependency.class);
+        when(dep1.getGroupId()).thenReturn("g1");
+        when(dep1.getArtifactId()).thenReturn("a1");
+        when(dep1.getType()).thenReturn(new org.apache.maven.api.Type() {


Same...

Done.

gnodet · 2025-11-18T19:53:28Z

impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultDependencyResolverResultTest.java

+        Dependency dep2 = mock(Dependency.class);
+        when(dep2.getGroupId()).thenReturn("g2");
+        when(dep2.getArtifactId()).thenReturn("a2");
+        when(dep2.getType()).thenReturn(new org.apache.maven.api.Type() {


Same...

Done.

gnodet · 2025-11-18T19:53:34Z

impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultDependencyResolverResultTest.java

+        Dependency mainDep = mock(Dependency.class);
+        when(mainDep.getGroupId()).thenReturn("gX");
+        when(mainDep.getArtifactId()).thenReturn("aX");
+        when(mainDep.getType()).thenReturn(new org.apache.maven.api.Type() {


Same...

Done.

gnodet · 2025-11-18T19:53:40Z

impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultDependencyResolverResultTest.java

+        Dependency patchDep = mock(Dependency.class);
+        when(patchDep.getGroupId()).thenReturn("gX");
+        when(patchDep.getArtifactId()).thenReturn("aX"); // same identifiers -> findArtifactPath should find mainDep
+        when(patchDep.getType()).thenReturn(new org.apache.maven.api.Type() {


Same...

Done.

vijaykriishna · 2025-11-19T00:12:10Z

Using DefaultType will remove 150 lines of code and will make the test more readable.

Done.

gnodet · 2025-11-26T08:56:52Z

impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultDependencyResolverResultTest.java

+        when(dep.getArtifactId()).thenReturn("a");
+        when(dep.getType())
+                .thenReturn(new DefaultType(
+                        "jar", org.apache.maven.api.Language.JAVA_FAMILY, "jar", null, false, JavaPathType.MODULES));


Consider using a method createJarType(JavaPathType.MODULES) that can be reused at the 5 locations. Alternatively, using constants could work too.

Consider using a method createJarType(JavaPathType.MODULES) that can be reused at the 5 locations. Alternatively, using constants could work too.

Came up with a reusable method.

gnodet

Use a method or constants instead of those long calls to the constructors.

vijaykriishna · 2025-11-27T06:57:36Z

Use a method or constants instead of those long calls to the constructors.

Came up with a reusable method.

vijaykriishna marked this pull request as ready for review November 8, 2025 00:55

gnodet requested changes Nov 18, 2025

View reviewed changes

gnodet added the maintenance label Nov 18, 2025

gnodet added this to the 4.1.0 milestone Nov 18, 2025

vijaykriishna force-pushed the tests/MNG-8697-DefaultDependencyResolverResultTest branch from 849ec97 to d0db7d2 Compare November 19, 2025 00:08

vijaykriishna requested a review from gnodet November 19, 2025 00:11

gnodet reviewed Nov 26, 2025

View reviewed changes

gnodet requested changes Nov 26, 2025

View reviewed changes

Adding DefaultDependencyResolverResultTest

dafad48

vijaykriishna force-pushed the tests/MNG-8697-DefaultDependencyResolverResultTest branch from d76590a to dafad48 Compare November 27, 2025 06:56

vijaykriishna requested a review from gnodet November 27, 2025 06:56

tests(maven#10389): Adding DefaultDependencyResolverResultTest #11410

Are you sure you want to change the base?

tests(maven#10389): Adding DefaultDependencyResolverResultTest #11410

Uh oh!

Conversation

vijaykriishna commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gnodet left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vijaykriishna commented Nov 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gnodet left a comment

Choose a reason for hiding this comment

Uh oh!

vijaykriishna commented Nov 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vijaykriishna commented Nov 8, 2025 •

edited

Loading