-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-7851] Improve error message when modelVersion is 4.0 #1210
Conversation
Improve DefaultModelValidator.compareModelVersions to be able to compare versions which different numbers of segments, allowing it to compare "4", "4.0", and "4.0.0" to each other for example. Signed-off-by: Craig Andrews <candrews@integralblue.com>
This will very likely violate the generated XML Schema. Moreover, the validator prints a hard version. I consider this change wrong. |
How does it violate the schema? Can you point me to something? The result of this change is only that the error message changes - no other behavior changes. In this PR, I added a unit test that demonstrates this change in error messaging behavior for this situation.
I'm sorry, I don't understand... Can you please clarify, perhaps with an example? |
Currently, Maven does require it to be the literal This PR adjusts the error message that is returned when attempts to use non- |
I take my first comment back. Thanks for this clarification. |
And to do what? I don't see where is the error message adjusted... what do i miss? |
The new test case at Line 120 in 78da8ff
'modelVersion' of '4.0' is newer than the versions supported by this version of Maven: [4.0.0]. Building this project requires a newer version of Maven. And with this PR, as this test case proves, the error message is 'modelVersion' must be one of [4.0.0] but is '4.0'. .
|
LGTM |
then please approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going litteral, shouldn't we simply check that the version in the model is one of the supported version. The validateModelVersion
could be simplified to just check the version is supported or thrown an exception without having to check for newer / older versions.
The "version comparing"-like code is there (and was) only for "meaningful" error message: newer -> you need newer maven. But i agree, to me this looks overly complicated as well (or just use Version class instead?) |
@candrews could you simplify the code for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed my mind... LGTM
MNG-7851 Improve error message when modelVersion is 4.0
Improve
DefaultModelValidator.compareModelVersions
to be able to compare versions which different numbers of segments, allowing it to compare "4", "4.0", and "4.0.0" to each other for example.Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY
,where you replace
MNG-XXX
andSUMMARY
with the appropriate JIRA issue.[MNG-XXX] SUMMARY
.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.