Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6207] display deprecation build warning for dependencies with scope 'system' declaration #123

Closed
wants to merge 1 commit into from

Conversation

dejan2609
Copy link
Contributor

@dejan2609 dejan2609 commented Jun 7, 2017

JIRA ticket: MNG-6207: Create WARNINGs in case of using system scope

Note: this PR is created instead of #119

@khmarbaise: FYI

…ope 'system' declaration

Note about tests: existing 'systemPath' related tests are reused/expanded (rationale: scope 'system' and 'systemPath' are mutually dependent)
@khmarbaise
Copy link
Member

First build has failed based on violated checkstyle rules. So best is before you open a pull request to run a full build via mvn clean verfiy on the whole Maven project...the checkstyle rules will be checked as part of the build...

@khmarbaise
Copy link
Member

Second build after fixing the checkstyle issues has worked. Integration into master done. You can close the pull request. Thank for your help to make Maven better.

@dejan2609
Copy link
Contributor Author

Just for the record: somehow it slipped of my mind that package phase doesn't execute integration tests (http://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html#default_Lifecycle) and hence this checkstyle error pass unnoticed on my side:

[ERROR] src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java[471:104] (blocks) LeftCurly: '{' should be on a new line.

Thanx @khmarbaise for this correction and for overall review.

@dejan2609 dejan2609 closed this Jun 11, 2017
@dejan2609 dejan2609 deleted the MNG-6207 branch June 11, 2017 18:55
@dejan2609
Copy link
Contributor Author

dejan2609 commented Jun 11, 2017

Just one more thing that I recalled from my memory: I did tried to execute tests (http://maven.apache.org/core-its/core-it-suite) like this: mvn clean test -Prun-its but I received warning that profile doesn't exist:

[WARNING] The requested profile "run-its" could not be activated because it does not exist.

pzygielo pushed a commit to pzygielo/maven that referenced this pull request Jan 4, 2023
gnodet pushed a commit to gnodet/maven that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants