-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-7995] Switch to JLine to provide line editing #1279
Conversation
Will it be compatible with Maven 3.x and old maven-shared-utils? |
In what sense should that be compatible ? You mean if a plugin is using maven-shared-utils and use that to output stuff ? Do you have a specific plugin in mind that I could try ? I've done some test with the archetype plugin which is using the Prompter and that works nicely. I haven't specifically checked plugins using |
eg.
|
It works when using a terminal. However, when the output is redirected to a file, the ansi sequences are not stripped correctly when using the |
b059ad7
to
9f3733c
Compare
I've upgrade to latest JLine, which now includes Jansi. The integration with maven-shared-utils works correctly now. |
@slawekjaranowski would you mind having a look ? |
JIRA issue: https://issues.apache.org/jira/browse/MNG-7995
JLine used for:
It should also be used in the future for better transfer display, i.e. rewriting
ConsoleMavenTransferListener
, still TODO, see #1302 as a possible base.