[MNG-8211] Fail the build if CI Friendly revision used without value

[cstamas]

As this is almost always source of confusion. If feature is used and there is no proper value set, fail the build, as users for sure does not plan to deploy artifacts with version ${revision} (or any expression in project.version).

Still, to not be disruptive, the old behaviour can be achieved by setting maven.build.allowExpressionInEffectiveProjectVersion=true project property.

---

https://issues.apache.org/jira/browse/MNG-8211

[cstamas]

Example failure: https://gist.github.com/cstamas/9dbb79be59ba22b6bc5c823d95593e50

[laeubi]

It seems currently only one value is assumed but one can combine values e.g.

<version>${revision}${sha1}${changelist}</version>

see

maven/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java

Lines 1231 to 1245 in 76ff89f

	Matcher m = CI_FRIENDLY_EXPRESSION.matcher(string.trim());
	while (m.find()) {
	String property = m.group(1);
	if (!versionProcessor.isValidProperty(property)) {
	addViolation(
	problems,
	severity,
	version,
	fieldName,
	null,
	"contains an expression but should be a constant.",
	tracker);
	return false;
	}
	}

[cstamas]

This PR does it in wrong place:

• this should happen in validator when validating effective model?

[cstamas]

Example of failure: https://gist.github.com/cstamas/01b1b6152aca56f1383148ef74245583

[cstamas]

This PR would really help to reduce user confusion with CI Friendly version.
Combined with Nisse https://github.com/maveniverse/nisse they can have full experience.

[cstamas]

Last example of failure but also the "escape hatch" in effect: https://gist.github.com/cstamas/1e880b2381bf1c543db052a1298e5074