Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNG-6414 Add more Apache license headers to skip downloading license … #167

Merged
merged 1 commit into from
Sep 16, 2018
Merged

MNG-6414 Add more Apache license headers to skip downloading license … #167

merged 1 commit into from
Sep 16, 2018

Conversation

slachiewicz
Copy link
Member

…text

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slachiewicz
Copy link
Member Author

The side effect is skip of downloading the license file from www.apache.org what produces error on Java 7

@slachiewicz slachiewicz force-pushed the fix/MNG-6414-apache-license branch from 531d45a to 7e01e81 Compare June 25, 2018 10:21
@slachiewicz slachiewicz force-pushed the fix/MNG-6414-apache-license branch from 7e01e81 to ae494f3 Compare July 11, 2018 12:19
@slachiewicz slachiewicz force-pushed the fix/MNG-6414-apache-license branch from ae494f3 to 549766c Compare July 20, 2018 08:51
@slachiewicz slachiewicz force-pushed the fix/MNG-6414-apache-license branch from 549766c to 89bb655 Compare September 9, 2018 09:50
@slachiewicz
Copy link
Member Author

license files in lib directory before patch:

Directory of maven-3.6.0-SNAPSHOT\lib
09/07/2018  01:27 AM            23,505 cdi-api.license
09/07/2018  01:27 AM            11,358 commons-cli.license
09/07/2018  01:27 AM            11,358 commons-io.license
09/07/2018  01:27 AM            11,358 commons-lang3.license
09/07/2018  01:27 AM               194 jcl-over-slf4j.license
09/07/2018  01:27 AM                 0 jsr250-api.license
09/07/2018  01:27 AM            11,358 maven-artifact.license
09/07/2018  01:27 AM            11,358 maven-builder-support.license
09/07/2018  01:27 AM            11,358 maven-compat.license
09/07/2018  01:27 AM            11,358 maven-core.license
09/07/2018  01:27 AM            11,358 maven-embedder.license
09/07/2018  01:27 AM            11,358 maven-model-builder.license
09/07/2018  01:27 AM            11,358 maven-model.license
09/07/2018  01:27 AM            11,358 maven-plugin-api.license
09/07/2018  01:27 AM            11,358 maven-repository-metadata.license
09/07/2018  01:27 AM            11,358 maven-resolver-api.license
09/07/2018  01:27 AM            11,358 maven-resolver-connector-basic.license
09/07/2018  01:27 AM            11,358 maven-resolver-impl.license
09/07/2018  01:27 AM            11,358 maven-resolver-provider.license
09/07/2018  01:27 AM            11,358 maven-resolver-spi.license
09/07/2018  01:27 AM            11,358 maven-resolver-transport-wagon.license
09/07/2018  01:27 AM            11,358 maven-resolver-util.license
09/07/2018  01:27 AM            11,358 maven-settings-builder.license
09/07/2018  01:27 AM            11,358 maven-settings.license
09/07/2018  01:27 AM            11,358 maven-shared-utils.license
09/07/2018  01:27 AM            11,358 maven-slf4j-provider.license
09/07/2018  01:27 AM            12,637 org.eclipse.sisu.inject.license
09/07/2018  01:27 AM            12,637 org.eclipse.sisu.plexus.license
09/07/2018  01:27 AM            23,505 plexus-cipher.license
09/07/2018  01:27 AM            11,358 plexus-component-annotations.license
09/07/2018  01:27 AM            11,358 plexus-interpolation.license
09/07/2018  01:27 AM            23,505 plexus-sec-dispatcher.license
09/07/2018  01:27 AM            11,358 plexus-utils.license
09/07/2018  01:27 AM               194 slf4j-api.license
09/07/2018  01:27 AM            11,358 wagon-file.license
09/07/2018  01:27 AM            11,358 wagon-http.license
09/07/2018  01:27 AM            11,358 wagon-provider-api.license

after:

 Directory of lib\MNG-6414

09/09/2018  06:02 PM               194 jcl-over-slf4j.license
09/09/2018  06:02 PM                 0 jsr250-api.license
09/09/2018  06:02 PM            12,637 org.eclipse.sisu.inject.license
09/09/2018  06:02 PM            12,637 org.eclipse.sisu.plexus.license
09/09/2018  06:02 PM               194 slf4j-api.license

Maven's zip ackage size decreased from 9 011 332 to 8 867 711 bytes.

@hboutemy
Copy link
Member

hboutemy commented Sep 9, 2018

wow, little cause with bigger effects than expected!
nice catch!

@slachiewicz slachiewicz force-pushed the fix/MNG-6414-apache-license branch from 89bb655 to b29277a Compare September 16, 2018 12:50
slachiewicz added a commit to slachiewicz/maven that referenced this pull request Sep 16, 2018
@slachiewicz
[MNG-6414] Add more Apache license header patterns to skip downloadin…
b29277a 
…g Apache license

Additional patterns for the Apache license exception list:
"Apache License, Version 2.0"
"The Apache Software License, Version 2.0"
"ASLv2"
"Apache Public License 2.0"

Fixes apache#167
@slachiewicz
[MNG-6414] Add more Apache license header patterns to skip downloadin…
ce6cc5d 
…g Apache license

Additional patterns for the Apache license exception list:
"Apache License, Version 2.0"
"The Apache Software License, Version 2.0"
"ASLv2"
"Apache Public License 2.0"

Fixes apache#167
@slachiewicz slachiewicz force-pushed the fix/MNG-6414-apache-license branch from b29277a to ce6cc5d Compare September 16, 2018 12:56
@asfgit asfgit merged commit ce6cc5d into apache:master Sep 16, 2018
asfgit pushed a commit that referenced this pull request Oct 24, 2018
@slachiewicz @khmarbaise
[MNG-6414] Add more Apache license header patterns to skip downloadin…
c2306d2 
…g Apache license

Additional patterns for the Apache license exception list:
"Apache License, Version 2.0"
"The Apache Software License, Version 2.0"
"ASLv2"
"Apache Public License 2.0"

Fixes #167
@slachiewicz slachiewicz deleted the fix/MNG-6414-apache-license branch January 14, 2019 00:47
gnodet added a commit to gnodet/maven that referenced this pull request Nov 20, 2024
@gnodet
[MNG-7360] Add an IT for build consumer with tags in plugin configs (a…
34fe4f4 
…pache#167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slachiewicz @hboutemy @asfgit