[MNG-8233] Client should handle modelIds as "opaque" #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javadoc states wrong things (about format of modelId, they are paths in reality), but also these all are "implementation details". Crafting modelIds to "walk" lineage is wrong, there is a dedicated method that provide "opaque" key Strings in defined order to do that. And client should not care (nor assume) anything about format of the key String. --- https://issues.apache.org/jira/browse/MNG-8233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javadoc states wrong things (about format of modelId, they are paths in reality), but also these all are "implementation details". Crafting modelIds to "walk" lineage is wrong, there is a dedicated method that provide "opaque" key Strings in defined order to do that. And client should not care (nor assume) anything about format of the key String.
As per MNG-8233, "modelIds" in Maven4 are NOT
g:a:vs as Javadoc wrongly states, but paths.https://issues.apache.org/jira/browse/MNG-8233