[MNG-8230] Rewrite CI friendly versions #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
force-pushed
the
MNG-8230
branch
6 times, most recently
from
668da63 to
970bf26
Compare
Yes, it requires a session scope which is not well supported by the sisu/di bridge. I'll rebase once #1722 is merged. |
gnodet
force-pushed
the
MNG-8230
branch
2 times, most recently
from
8685029 to
3581881
Compare
|
IMO, the proper way of working for CFV is:
Or I miss something? |
This role is supposed to be hold by the |
gnodet
force-pushed
the
MNG-8230
branch
2 times, most recently
from
fcf7337 to
4805dbe
Compare
cstamas
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Friendly versions are now fully opened, so not limited anymore to the 3 predefined properties which were
sha1,changelistandrevision.So expression on version and parent version are interpolated with their proper values, taken from the session user properties and from the session's root project properties (uninterpolated).
An additional validation check after computing this file model to ensure that no expression is used in version at this point. This ensures that during the next step (raw model build), all the full GAV are known, as they will be used to infer missing dependency information. It allows remove possible problems with plugins, not being fully aware of those versions.
JIRA issue: https://issues.apache.org/jira/browse/MNG-8230
IT PR: apache/maven-integration-testing#366