Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rootDirectory mandatory #1787

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Make rootDirectory mandatory #1787

merged 5 commits into from
Oct 8, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Oct 8, 2024 •
edited
Loading

Make rootDirectory mandatory. Expose locator (and detectors) via ServiceLoaders, as with polyglot more detector may be needed (ie polyglot extension will need to register own "detector").

@cstamas
Ability to provide custom rootDirectory fallback
cc44633 
As in case of mvnd it is provided by client, and
mvnd parser should not set system properties to
make base parser able to figure out location of
rootDirectory.
@cstamas cstamas requested a review from gnodet October 8, 2024 12:46
@cstamas cstamas self-assigned this Oct 8, 2024
@cstamas cstamas marked this pull request as ready for review October 8, 2024 12:48
@gnodet
Copy link
Contributor

gnodet commented Oct 8, 2024

I don't really see why we would default rootDirectory to ${maven.multimoduleDirectory}.
The mvnd client does not have to set the rootDirectory, only the cwd and arguments. It also set ${maven.multimoduleDirectory} for backward compatibility.

gnodet
gnodet approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you have a look at my changes?
I'm fine otherwise.

@cstamas
Copy link
Member Author

cstamas commented Oct 8, 2024

Looks good +1

@gnodet gnodet changed the title Ability to provide custom rootDirectory fallback Make rootDirectory mandatory Oct 8, 2024
@gnodet gnodet merged commit 4452363 into apache:master Oct 8, 2024
13 checks passed
@gnodet gnodet added this to the 4.0.0-beta-5 milestone Oct 8, 2024
@cstamas cstamas deleted the parser-rootdir-fallback branch October 8, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnodet gnodet gnodet approved these changes

Assignees

@cstamas cstamas

Labels
None yet
Projects
None yet
Milestone
4.0.0-beta-5
Development

Successfully merging this pull request may close these issues.
2 participants
@cstamas @gnodet