Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8312] Generate the BOM automatically #1797

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Oct 15, 2024

JIRA issue: MNG-8312

@gnodet gnodet added this to the 4.0.0-beta-5 milestone Oct 15, 2024
@gnodet gnodet marked this pull request as draft October 16, 2024 15:15
@gnodet
Copy link
Contributor Author

gnodet commented Oct 16, 2024

I wonder if we should make the BOM have no parent at all, that would be easier to manage.
@slawekjaranowski @cstamas ?

@cstamas
Copy link
Member

cstamas commented Oct 16, 2024

Yup, BOM is generated and is attached, it does not need SCM and parent...

@cstamas
Copy link
Member

cstamas commented Oct 16, 2024

Also, our plugins are akin to "fat BOM" as well, to not have add those "locked to Maven version" comments all over the place

@gnodet gnodet marked this pull request as ready for review October 16, 2024 20:51
Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont we want "fat BOM" as well? Or what is your plan?

@gnodet
Copy link
Contributor Author

gnodet commented Oct 17, 2024

@cstamas
Copy link
Member

cstamas commented Oct 17, 2024

I love the "fat" one! No more "locked to maven...." comment on properties in plugins!

@gnodet gnodet merged commit d5c8280 into apache:master Oct 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants