Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6527] - Add unit tests for org.apache.maven.repository.MavenArtifactMetadata #196

Closed

Conversation

diffblue-assistant
Copy link

Hi,

I've analysed your codebase and produced some unit tests for the following classes - org.apache.maven.repository.MavenArtifactMetadata.

I've written the tests for these functions with the help of Diffblue Cover.

Hopefully, these tests should help you detect regressions caused by future code changes.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…factMetadata

These tests were written by Diffblue Cover.
Copy link
Member

@slachiewicz slachiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use diffrent values for group and artifactId

It would be best if You can collect and create PR for all additional tests per project module - not per class. Also maven-compat module is „old” and deprecated - we not expect to modify code here.

Thx for contribution and looking for more fuzzy tests :)

@michael-o
Copy link
Member

I think that there is no benefit in merging this one.

@michael-o michael-o closed this Dec 28, 2018
gnodet added a commit to gnodet/maven that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants