Skip to content

Avoid warning about unthrown exception #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elharo merged 2 commits into from
Apr 14, 2025
Merged

Avoid warning about unthrown exception #2217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cebaf19
Avoid warning about unthrown exception
elharo Apr 1, 2025
f77034d
revert accidental change
elharo Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions impl/maven-impl/src/test/java/org/apache/maven/impl/ModelVersionParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,23 +24,21 @@
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail;

/**
*/
public class ModelVersionParserTest {

private final DefaultModelVersionParser versionParser = new DefaultModelVersionParser(new GenericVersionScheme());

private VersionParserException parseInvalid(String constraint) {
private void parseInvalid(String constraint) {
try {
versionParser.parseVersionConstraint(constraint);
fail("expected exception for constraint " + constraint);
return null;
} catch (VersionParserException e) {
return e;
assertNotNull(e.getMessage());
}
}

Expand Down