Skip to content

chore: drop obsolete DefaultXmlService#findNodeById #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pankraz76 wants to merge 1 commit into from
Closed

chore: drop obsolete DefaultXmlService#findNodeById #2334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions impl/maven-xml/src/main/java/org/apache/maven/internal/xml/DefaultXmlService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,34 +392,6 @@ private static String getChildCombinationMode(Map<String, String> attributes) {
return !isEmpty(value) ? value : DEFAULT_CHILDREN_COMBINATION_MODE;
}

@Nullable
private static XmlNode findNodeById(@Nonnull List<XmlNode> nodes, @Nonnull String id) {
return nodes.stream()
.filter(n -> id.equals(n.attribute(ID_COMBINATION_MODE_ATTRIBUTE)))
.findFirst()
.orElse(null);
}

@Nullable
private static XmlNode findNodeByKeys(
@Nonnull List<XmlNode> nodes, @Nonnull XmlNode target, @Nonnull String[] keys) {
return nodes.stream()
.filter(n -> matchesKeys(n, target, keys))
.findFirst()
.orElse(null);
}

private static boolean matchesKeys(@Nonnull XmlNode node1, @Nonnull XmlNode node2, @Nonnull String[] keys) {
for (String key : keys) {
String value1 = node1.attribute(key);
String value2 = node2.attribute(key);
if (!Objects.equals(value1, value2)) {
return false;
}
}
return true;
}

static class IndentingXMLStreamWriter extends StreamWriterDelegate {

int depth = 0;
Expand Down