dedicate class CheckThreadSafetyThread from CheckThreadSafetyMojo for concern checkThreadSafety
#2382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
changed the title
CheckThreadSafetyThread from CheckThreadSafetyMojo for concern checkThreadSafetyCheckThreadSafetyThread from CheckThreadSafetyMojo for concern checkThreadSafety
Pankraz76
pushed a commit
to Pankraz76/maven
that referenced
this pull request
May 23, 2025
… concern checkThreadSafety apache#2382
Pankraz76
force-pushed
the
CheckThreadSafetyThread-CountDownLatch-EmptyControlStatement-CheckThreadSafetyMojo
branch
from
0d52b22 to
d933562
Compare
Pankraz76
commented
May 23, 2025
| final CountDownLatch startLatch = new CountDownLatch(1); | ||
| final Thread[] threads = new Thread[2]; | ||
| for (int i = 0; i < threads.length; i++) { | ||
| // NOTE: The threads need to use different realms to trigger changes of the collections |
Contributor
Author
There was a problem hiding this comment.
might be candidate for @implNote to give special attention, thus higher scope.
| private final ClassLoader tccl = cl; | ||
|
|
||
| public void run() { | ||
| getLog().info("[MAVEN-CORE-IT-LOG] Thread " + this + " uses " + tccl); |
Contributor
Author
There was a problem hiding this comment.
this comes from the logger normally, right? its kind of dry:
...in-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java
Outdated
Show resolved
Hide resolved
Pankraz76
commented
May 23, 2025
| for (int i = 0; i < threads.length; i++) { | ||
| // NOTE: The threads need to use different realms to trigger changes of the collections | ||
| final ClassLoader cl = (i % 2) == 0 ? pluginRealm : coreRealm; | ||
| threads[i] = new Thread() { |
Contributor
Author
There was a problem hiding this comment.
why no runnable? we only implement run method so this is kind of funny.
Pankraz76
pushed a commit
to Pankraz76/maven
that referenced
this pull request
May 23, 2025
… concern checkThreadSafety apache#2382
Pankraz76
force-pushed
the
CheckThreadSafetyThread-CountDownLatch-EmptyControlStatement-CheckThreadSafetyMojo
branch
from
d933562 to
101e65a
Compare
Pankraz76
pushed a commit
to Pankraz76/maven
that referenced
this pull request
May 23, 2025
… concern checkThreadSafety apache#2382
Pankraz76
force-pushed
the
CheckThreadSafetyThread-CountDownLatch-EmptyControlStatement-CheckThreadSafetyMojo
branch
from
101e65a to
f28aed5
Compare
Pankraz76
commented
May 23, 2025
| * | ||
| * @implNote threads need to use different realms to trigger changes of the collections. | ||
| */ | ||
| public void execute() throws MojoExecutionException { |
Contributor
Author
There was a problem hiding this comment.
require test coverage.
Contributor
Author
There was a problem hiding this comment.
test for test seems strange.
Pankraz76
pushed a commit
to Pankraz76/maven
that referenced
this pull request
May 23, 2025
… concern checkThreadSafety apache#2382
… concern checkThreadSafety
Pankraz76
force-pushed
the
CheckThreadSafetyThread-CountDownLatch-EmptyControlStatement-CheckThreadSafetyMojo
branch
from
f28aed5 to
1eac488
Compare
Contributor
Author
|
wip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while(true)withCountDownLatchinCheckThreadSafetyMojo#2381Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY,where you replace
MNG-XXXandSUMMARYwith the appropriate JIRA issue.[MNG-XXX] SUMMARY.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.