Skip to content

[maven-4.0.x] Fix ReactorReader incorrect warnings and logic (fixes #2497, #2498) #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnodet merged 1 commit into from
Jul 2, 2025
Merged

[maven-4.0.x] Fix ReactorReader incorrect warnings and logic (fixes #2497, #2498) #2536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions impl/maven-core/src/main/java/org/apache/maven/ReactorReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,12 @@ public File findArtifact(Artifact artifact) {
// No project, but most certainly a dependency which has been built previously
File packagedArtifactFile = findInProjectLocalRepository(artifact);
if (packagedArtifactFile != null && packagedArtifactFile.exists()) {
// Check if artifact is up-to-date
project = getProject(artifact, getAllProjects());
if (project != null) {
isPackagedArtifactUpToDate(project, packagedArtifactFile);
// Check if artifact is up-to-date (only for non-POM artifacts)
if (!"pom".equals(artifact.getExtension())) {
project = getProject(artifact, getAllProjects());
if (project != null) {
isPackagedArtifactUpToDate(project, packagedArtifactFile);
}
}
return packagedArtifactFile;
}
Expand Down Expand Up @@ -176,7 +178,9 @@ private File findArtifact(MavenProject project, Artifact artifact, boolean check
File packagedArtifactFile = findInProjectLocalRepository(artifact);
if (packagedArtifactFile != null
&& packagedArtifactFile.exists()
&& (!checkUptodate || isPackagedArtifactUpToDate(project, packagedArtifactFile))) {
&& (!checkUptodate
|| "pom".equals(artifact.getExtension())
|| isPackagedArtifactUpToDate(project, packagedArtifactFile))) {
return packagedArtifactFile;
}

Expand Down Expand Up @@ -252,7 +256,14 @@ private boolean isPackagedArtifactUpToDate(MavenProject project, File packagedAr
+ "please run a full `mvn package` build",
relativizeOutputFile(outputFile),
project.getArtifactId());
return true;
return false;
} else if (LOGGER.isDebugEnabled()) {
LOGGER.debug(
"File '{}' timestamp {} vs artifact timestamp {} for '{}'",
relativizeOutputFile(outputFile),
outputFileLastModified,
artifactLastModified,
project.getArtifactId());
}
}

Expand Down