Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc) MNGSITE-353: Document maven.repo.local property #265

Closed
wants to merge 1 commit into from

Conversation

AElMehdi
Copy link
Contributor

@AElMehdi AElMehdi commented Jul 4, 2019

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@AElMehdi
Copy link
Contributor Author

AElMehdi commented Jul 4, 2019

@hboutemy,
As discussed before I changed the documentation of the org.apache.maven.model.interpolation.StringSearchModelInterpolator based on what it existed in the previous maven version.
I tried to figure out from the code if it still existed/used which apparently is, since it's referenced in some tests/classes!
Thanks.

@@ -184,6 +184,8 @@ Maven Model Builder
*----+------+------+
| <<<maven.build.version>>> | The full build version of the current Maven execution <(since 3.0.4)>. For example, "<<<Apache Maven 3.2.2 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19T14:51:28+01:00)>>>". | <<<$\{maven.build.version\}>>> |
*----+------+------+
| <<<maven.repo.local>>> | The repository on the local machine Maven should use to store downloaded artifacts (jars etc). | <<<$\{${user.home}/.m2/repository\}>>> |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong here: <<<$\{${user.home}/.m2/repository\}>>>. Too many braces and dollars.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the redundant ones.

@asfgit asfgit closed this in 8da81ce Jul 6, 2019
asfgit pushed a commit that referenced this pull request Jul 12, 2019
@AElMehdi AElMehdi deleted the MNGSITE-353_doc branch September 11, 2019 15:57
gnodet added a commit to gnodet/maven that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants