Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6912] - File based profile activation results in absolute paths in OriginalModel #348

Closed
wants to merge 1 commit into from

Conversation

glimmerveen
Copy link

@glimmerveen glimmerveen commented May 22, 2020

Determine active profiles based on 'tmpModel' rather than 'rawModel', thus ensuring the 'rawModel' is not modified in any way.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…in OriginalModel

Determine active profiles based on 'tmpModel' rather than 'rawModel', thus ensuring the 'rawModel' is not modified in any way.
@glimmerveen
Copy link
Author

I did try to execute the integration tests suite, but I got the following warning:

The requested profile "run-its" could not be activated because it does not exist.

@glimmerveen
Copy link
Author

Coincidentally there is a parallel PR #347 that solves the same issue, but in a different way.

@basvandenbrink
Copy link

This has been an issue for quite some time and this pull request has been created 10 months ago. Is there any chance that this one gets approved?

@michael-o / @MartinKanters could you take a look at this?

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is very little chance this will be approved or even reviewed unless it's up to date with head. There's no point in pinging people until master is merged in and conflicts are resolved.

@glimmerveen
Copy link
Author

Closed as #347, which fixes the same issue, has been merged, so there is no need for this PR anymore.

gnodet pushed a commit to gnodet/maven that referenced this pull request Nov 20, 2024
apache#348)

* [MNG-7758] Report dependency problems for all repository - extends ITs

* [MNG-7758] Report dependency problems for all repository - extends ITs

* [MNG-7758] Report dependency problems for all repository - extends ITs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants