Code

Refactor MavenCli.populateRequest#351

Code

Closed

mthmulders wants to merge 33 commits intoapache:masterapache/maven:masterfrom infosupport:refactor-mavencli-populaterequestinfosupport/maven:refactor-mavencli-populaterequestCopy head branch name to clipboard

+344-211

Commits

Commits on Sep 19, 2020

• Remove Checkstyle suppression about method length

  mthmulders

  committed
  c949e73

• Extract method warnAboutDeprecatedOptionsUsed

  mthmulders

  committed
  ee0d2b0

• Rewrite warnAboutDeprecatedOptionsUsed to use a Stream

  mthmulders

  committed
  17b6281

• Immediately set noSnapshotUpdates

  mthmulders

  committed
  5c48ab1

• Immediately set recursive

  mthmulders

  committed
  95ac87f

• Immediately set updateSnapshots

  mthmulders

  committed
  fd3fba8

• Immediately set showErrors

  mthmulders

  committed
  5a72507

• Immediately set goals

  mthmulders

  committed
  860c0f0

• Extract method determineMakeBehavior

  mthmulders

  committed
  ddd810f

• Extract method determineGlobalCheckPolicy

  mthmulders

  committed
  18f9328

• Extract method determineReactorFailureBehaviour

  mthmulders

  committed
  8bae4e6

• Extract method determineTransferListener

  mthmulders

  committed
  46f4aee

• Extract method determineExecutionListener

  mthmulders

  committed
  d1f1fd3

• Extract method determineProfileActivation and add tests

  mthmulders

  committed
  89bc3ed

• Extract method determineProjectActivation and add tests

  mthmulders

  committed
  36825ac

• Return value for getOptionValue is null when option not present

  mthmulders

  committed
  c86e684

• Inline setting boolean params

  mthmulders

  committed
  a0f383a

• Remove superfluous whitespace

  mthmulders

  committed
  79fdd98

• Extract method determinePom

  mthmulders

  committed
  d4b178f

• Reformat

  mthmulders

  committed
  ec748c6

• Re-order method

  mthmulders

  committed
  5b4b22a

• Move determining the baseDirectory to DefaultMavenExecutionRequest

  mthmulders

  committed
  7f67f75

• Extract method determineLocalRepositoryPath

  mthmulders

  committed
  8dba43e

• Simplify method determineLocalRepositoryPath

  mthmulders

  committed
  1da3a5e

• The buildId cannot be null - needs a default value

  mthmulders

  committed
  d6aa7d0

• Revert "Move determining the baseDirectory to DefaultMavenExecutionRequest"

  Show description for daa2471
  mthmulders

  committed
  daa2471

• Replace @VisibleForTesting with a comment

  mthmulders

  committed
  be91f05

• Rename warnAboutDeprecatedOptionsUsed to handleDeprecatedOptions

  mthmulders

  committed
  69c8ead

• Accidentally reversed working of the -U flag

  mthmulders

  committed
  9ad446c

• Inlining CLI flags could unintentionally toggle flags

  Show description for e5e2477
  mthmulders

  committed
  e5e2477

• Move determining the baseDirectory to DefaultMavenExecutionRequest

  mthmulders

  committed
  430c9f9

• Line length

  mthmulders

  committed
  6865d0e

• Explicitly instantiate primitive boolean values

  mthmulders

  committed
  a2e36c3