Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6972] allow access to org.apache.maven.graph #368

Closed
wants to merge 1 commit into from
Closed

[MNG-6972] allow access to org.apache.maven.graph #368

wants to merge 1 commit into from

Conversation

mickroll
Copy link
Contributor

@mickroll mickroll commented Aug 3, 2020

fixes MNG-6972

With this PR, maven extensions can access the GraphBuilder to update the dependency graph after adding dependencies.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@mickroll
Copy link
Contributor Author

mickroll commented Aug 3, 2020

Failing test:

[ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 256.781 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
[ERROR] testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)  Time elapsed: 0.174 s  <<< ERROR!
org.apache.maven.it.VerificationException: Text not found in log: Could not transfer artifact org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
	at org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)

Can't see why this fails for the change in this PR.

Hint: this test runs fine on my machine:

[INFO] Running org.apache.maven.it.MavenITmng5175WagonHttpTest
58 [main] INFO org.eclipse.jetty.server.Server - jetty-9.0.4.v20130625
152 [main] INFO org.eclipse.jetty.server.ServerConnector - Started ServerConnector@7d900ecf{HTTP/1.1}{0.0.0.0:60411}
Bound server socket to the port 60411
mng5175 WagonHttp.mng5175_ReadTimeOutFromSettings().......... OK (2.5 s)
2697 [main] INFO org.eclipse.jetty.server.ServerConnector - Stopped ServerConnector@7d900ecf{HTTP/1.1}{0.0.0.0:0}
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.893 s - in org.apache.maven.it.MavenITmng5175WagonHttpTest

@michael-o
Copy link
Member

It is probably ephemeral.

@mickroll
Copy link
Contributor Author

mickroll commented Aug 3, 2020

Added integration test: apache/maven-integration-testing#69

this is needed for rebuilding the dependency graph during build extension execution after changing dependencies

fixes MNG-6972
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. @rfscholte IT is fine too. Any objections?

@rfscholte
Copy link
Contributor

LGTM

@asfgit asfgit closed this in 6087444 Aug 4, 2020
@mickroll mickroll deleted the MNG-6972 branch August 5, 2020 07:14
asfgit pushed a commit that referenced this pull request Mar 6, 2022
This is, for example, needed for rebuilding the dependency graph during build
extension execution after changing dependencies.

This closes #368
gnodet pushed a commit to gnodet/maven that referenced this pull request Apr 12, 2022
This is, for example, needed for rebuilding the dependency graph during build
extension execution after changing dependencies.

This closes apache#368
asfgit pushed a commit that referenced this pull request Feb 18, 2023
This is, for example, needed for rebuilding the dependency graph during build
extension execution after changing dependencies.

This closes #368
gnodet added a commit to gnodet/maven that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants