-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-6972] allow access to org.apache.maven.graph #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing test:
Can't see why this fails for the change in this PR. Hint: this test runs fine on my machine:
|
It is probably ephemeral. |
Added integration test: apache/maven-integration-testing#69 |
this is needed for rebuilding the dependency graph during build extension execution after changing dependencies fixes MNG-6972
michael-o
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. @rfscholte IT is fine too. Any objections?
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Mar 6, 2022
This is, for example, needed for rebuilding the dependency graph during build extension execution after changing dependencies. This closes #368
gnodet
pushed a commit
to gnodet/maven
that referenced
this pull request
Apr 12, 2022
This is, for example, needed for rebuilding the dependency graph during build extension execution after changing dependencies. This closes apache#368
asfgit
pushed a commit
that referenced
this pull request
Feb 18, 2023
This is, for example, needed for rebuilding the dependency graph during build extension execution after changing dependencies. This closes #368
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes MNG-6972
With this PR, maven extensions can access the GraphBuilder to update the dependency graph after adding dependencies.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MNG-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.