-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-6113] Rename the 'Central Repository' to 'Maven Central Reposito… #392
Conversation
…ry' in the 4.0.0 super POM
@hboutemy has a strong opinion about this. |
I'd love to here it. I would expect that we use a canonical name which carries your name: Maven. |
@hboutemy What is your opinion? |
Central Repository is used not only by Maven |
Central has been initiated by Maven devs and even non-Maven users refer to it Maven Central. Are you saying that Central Repository is a trademark? I had this discussions once with Mark Thomas, the ASF does not hold any registrations as far as I remember. I did not fully understand what you were trying to say. |
I think I understand the issue here. Central contains artifacts: they don't have to be created by Maven, nor do they have to be consumed by Maven projects only. |
AFAIR, it was Maven Central before "re-branding", even the book mentions it as such, oh, and btw, it is in |
@rfscholte The layout, structure and meta files are dictated by the Maven community, maven-metadata.xml. If you claim this is a non-Maven repo I request to rename those files. |
It has been operated under the name "Central Repository" by Sonatype for well over a decade. I would leave the name alone I am opposed to merging this .. cc @brianf |
Well, https://search.maven.org/ names it differently 😄 |
@hboutemy seems it WAS registered, but is abandoned (since 2013?). This argument, actually both of them, are fluke IMHO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Actually, all this "discussion" is IMHO fluke:
In other words, if afore mentioned company tomorrow renames "Central" to "Ukulele" for whatever reason, will that imply Super POM change in Apache Maven as well? |
Hahah .. about search.maven.org .. oh well. The reason central.sonatype.org is important is that it is the reference documentation for how to publish .. maybe Sonatype and the Maven project should agree on one name and use it consistently.. Personally I am fine with calling it Ukulele as well @cstamas ;-) |
@cstamas As you pointed out on central.s.o "The Central Repository" is a stupid, generic name not telling its purpose at all. Central for what? While Maven Central Repository clearly says that it hosts something for Maven. As for the rest: while some has approved the PR, others didn't really make a clear statement. What is the concensus? |
We have also this file published on maven website so after merge we should refresh it manually |
…ry' in the 4.0.0 super POM
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MNG-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.