Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6113] Rename the 'Central Repository' to 'Maven Central Reposito… #392

Closed
wants to merge 1 commit into from

Conversation

michael-o
Copy link
Member

…ry' in the 4.0.0 super POM

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o michael-o requested a review from rfscholte November 13, 2020 16:52
@rfscholte
Copy link
Contributor

@hboutemy has a strong opinion about this.

@rfscholte rfscholte requested a review from hboutemy November 13, 2020 16:55
@michael-o
Copy link
Member Author

I'd love to here it. I would expect that we use a canonical name which carries your name: Maven.

@michael-o
Copy link
Member Author

michael-o commented Nov 16, 2020

@hboutemy What is your opinion?

@hboutemy
Copy link
Member

Central Repository is used not only by Maven
and "Maven Central" is a registered service name as stated in https://issues.apache.org/jira/browse/MNG-5164

@michael-o
Copy link
Member Author

Central has been initiated by Maven devs and even non-Maven users refer to it Maven Central. Are you saying that Central Repository is a trademark? I had this discussions once with Mark Thomas, the ASF does not hold any registrations as far as I remember. I did not fully understand what you were trying to say.

@rfscholte
Copy link
Contributor

I think I understand the issue here. Central contains artifacts: they don't have to be created by Maven, nor do they have to be consumed by Maven projects only.
For similar reason I chose to create plexus-languages/plexus-java: it might look weird if it was called maven-java and used by projects that have nothing to do with Maven , e.g. other build tools.

@cstamas
Copy link
Member

cstamas commented Nov 17, 2020

AFAIR, it was Maven Central before "re-branding", even the book mentions it as such, oh, and btw, it is in maven.org domain as well 😄

@michael-o
Copy link
Member Author

michael-o commented Nov 17, 2020

@rfscholte The layout, structure and meta files are dictated by the Maven community, maven-metadata.xml. If you claim this is a non-Maven repo I request to rename those files.

@mosabua
Copy link
Member

mosabua commented Nov 17, 2020

It has been operated under the name "Central Repository" by Sonatype for well over a decade. I would leave the name alone

https://central.sonatype.org/

I am opposed to merging this ..

cc @brianf

@cstamas
Copy link
Member

cstamas commented Nov 17, 2020

Well, https://search.maven.org/ names it differently 😄

@cstamas
Copy link
Member

cstamas commented Nov 17, 2020

Central Repository is used not only by Maven
and "Maven Central" is a registered service name as stated in https://issues.apache.org/jira/browse/MNG-5164

@hboutemy seems it WAS registered, but is abandoned (since 2013?). This argument, actually both of them, are fluke IMHO.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@cstamas
Copy link
Member

cstamas commented Nov 17, 2020

Actually, all this "discussion" is IMHO fluke:

  • we discuss a change in Apache Maven sources, what it has to do with a (publicly available, thanks!) service name that a privately held company operate and publicize?
  • Super POM points to https://repo.maven.apache.org/maven while https://central.sonatype.org/ is being mentioned here. What first thing has to do with second? (true, content-wise is "same thing", but is merely technical detail that former URL is backed by service operated by same company backing latter URL as well).
  • the repository as known today (aka "central place for binary artifacts", etc, any def you can come up for that repo) was conceived and laid down by Apache Maven project.
  • the name "maven central" name was registered back in 2011 (when issue MNG-5164 was created), but seems abandoned since, for over 7 years.

In other words, if afore mentioned company tomorrow renames "Central" to "Ukulele" for whatever reason, will that imply Super POM change in Apache Maven as well?

@mosabua
Copy link
Member

mosabua commented Nov 17, 2020

Hahah .. about search.maven.org .. oh well.

The reason central.sonatype.org is important is that it is the reference documentation for how to publish .. maybe Sonatype and the Maven project should agree on one name and use it consistently..

Personally I am fine with calling it Ukulele as well @cstamas ;-)

@michael-o
Copy link
Member Author

@cstamas As you pointed out on central.s.o "The Central Repository" is a stupid, generic name not telling its purpose at all. Central for what? While Maven Central Repository clearly says that it hosts something for Maven.

As for the rest: while some has approved the PR, others didn't really make a clear statement. What is the concensus?

@slachiewicz
Copy link
Member

slachiewicz commented Nov 22, 2020

We have also this file published on maven website so after merge we should refresh it manually

@michael-o michael-o closed this Feb 28, 2021
@michael-o michael-o deleted the MNG-6113 branch February 28, 2021 19:18
gnodet added a commit to gnodet/maven that referenced this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants