[MNG-6776] Inconsistent list of parameters for MojoDescriptor #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a JIRA issue for this? |
|
Nope, just @slachiewicz throwed together a test, it all started there #291 |
|
Ah ok, maybe this should be in one PR? |
cstamas
changed the title
gnodet
approved these changes
Dec 2, 2021
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java
Outdated
Show resolved
Hide resolved
It may lead to confusion as parameters (list) and parametersMap (map) may "fall apart" easily. Also, parametersMap did not honor parameter ordering while parameters list makes it look that order is important. Simply, rebuild the map always and retain ordering as well. Added UT and also removed some cruft provided by java8.
cstamas
force-pushed
the
do-not-keep-parameters-map
branch
from
4cb3167
to
038a976
Compare
cstamas
changed the title
|
@gnodet @michael-o @slachiewicz pls review (again Guillaume), cleaned up, pulled in @slachiewicz UT |
gnodet
reviewed
Dec 2, 2021
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java
Show resolved
Hide resolved
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java
Outdated
Show resolved
Hide resolved
asfgit
pushed a commit
that referenced
this pull request
Jan 2, 2024
It may lead to confusion as parameters (list) and parametersMap (map) may "fall apart" easily. Also, parametersMap did not honor parameter ordering while parameters list makes it look that order is important. Simply, rebuild the map always and retain ordering as well. Added UT and also removed some cruft provided by java8. --- https://issues.apache.org/jira/browse/MNG-7309
asfgit
pushed a commit
that referenced
this pull request
Jan 3, 2024
It may lead to confusion as parameters (list) and parametersMap (map) may "fall apart" easily. Also, parametersMap did not honor parameter ordering while parameters list makes it look that order is important. Simply, rebuild the map always and retain ordering as well. Added UT and also removed some cruft provided by java8. Co-authored-by: Marc Wrobel <marc.wrobel@gmail.com> Co-authored-by: Slawomir Jaranowski <s.jaranowski@gmail.com> --- https://issues.apache.org/jira/browse/MNG-7309
asfgit
pushed a commit
that referenced
this pull request
Jan 6, 2024
It may lead to confusion as parameters (list) and parametersMap (map) may "fall apart" easily. Also, parametersMap did not honor parameter ordering while parameters list makes it look that order is important. Simply, rebuild the map always and retain ordering as well. Added UT and also removed some cruft provided by java8. Co-authored-by: Marc Wrobel <marc.wrobel@gmail.com> Co-authored-by: Slawomir Jaranowski <s.jaranowski@gmail.com> (cherry picked from commit cc51006) (cherry picked from commit 5ce5591) (cherry picked from commit 47e2d68) --- https://issues.apache.org/jira/browse/MNG-7309
asfgit
pushed a commit
that referenced
this pull request
Jan 6, 2024
It may lead to confusion as parameters (list) and parametersMap (map) may "fall apart" easily. Also, parametersMap did not honor parameter ordering while parameters list makes it look that order is important. Simply, rebuild the map always and retain ordering as well. Added UT and also removed some cruft provided by java8. Co-authored-by: Marc Wrobel <marc.wrobel@gmail.com> Co-authored-by: Slawomir Jaranowski <s.jaranowski@gmail.com> (cherry picked from commit cc51006) (cherry picked from commit 5ce5591) (cherry picked from commit 47e2d68) --- https://issues.apache.org/jira/browse/MNG-7309
asfgit
pushed a commit
that referenced
this pull request
Jan 6, 2024
It may lead to confusion as parameters (list) and parametersMap (map) may "fall apart" easily. Also, parametersMap did not honor parameter ordering while parameters list makes it look that order is important. Simply, rebuild the map always and retain ordering as well. Added UT and also removed some cruft provided by java8. Co-authored-by: Marc Wrobel <marc.wrobel@gmail.com> Co-authored-by: Slawomir Jaranowski <s.jaranowski@gmail.com> (cherry picked from commit cc51006) (cherry picked from commit 5ce5591) (cherry picked from commit 47e2d68) --- https://issues.apache.org/jira/browse/MNG-7309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may lead to confusion as parameters (list) and
parametersMap (map) may "fall apart" easily.
Also, parametersMap did not honor parameter
ordering while parameters list makes it look
that order is important.
Simply, rebuild the map always and retain
ordering as well.
Added UT and also removed some cruft provided
by java8.
https://issues.apache.org/jira/browse/MNG-7309
See #291