-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure RAT plugin ignores files in the target folder #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed89752
to
79312b1
Compare
…in children, use a single place to configure rat
@michael-o @cstamas I gave it another try |
cstamas
approved these changes
Oct 5, 2022
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 5, 2022
* Make sure RAT plugin ignores files in the target folder * Fix gitignore so that it can work with rat, do not inherit execution in children, use a single place to configure rat * Exclude .asf.yaml from rat check * Add repo/ to the .gitignore file as it's often used for local repository
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 5, 2022
* Make sure RAT plugin ignores files in the target folder * Fix gitignore so that it can work with rat, do not inherit execution in children, use a single place to configure rat * Exclude .asf.yaml from rat check * Add repo/ to the .gitignore file as it's often used for local repository
gnodet
added a commit
that referenced
this pull request
Oct 5, 2022
* Make sure RAT plugin ignores files in the target folder * Fix gitignore so that it can work with rat, do not inherit execution in children, use a single place to configure rat * Exclude .asf.yaml from rat check * Add repo/ to the .gitignore file as it's often used for local repository
gnodet
added a commit
that referenced
this pull request
Oct 5, 2022
* Make sure RAT plugin ignores files in the target folder * Fix gitignore so that it can work with rat, do not inherit execution in children, use a single place to configure rat * Exclude .asf.yaml from rat check * Add repo/ to the .gitignore file as it's often used for local repository
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching branches, left-over
target
folder often causes issues with therat-maven-plugin
.Ignoring those folders does help from a day-to-day pov.
See #814 and #815