-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl) #942
Conversation
I don't have any problem with this PR. However, I wonder that the final outcome should be. In the long term, the repackaging is a bit of a hack and a pain to maintain, especially the xml part which is reimplemented. I see several solutions:
|
Why not move out the XML stuff to |
+1 for 3rd option |
Actually, a LOT of plexus should be ingested by maven stuff (as it is unused anywhere else), think compiler, think archiver, etc -- we must collapse these, as it is nightmare and just layers and layers of indirection... |
Too much pain, too much work! |
yes, splitting Plexus' plexus-utils 4.0.0 https://github.com/codehaus-plexus/plexus-utils into plexus-xml + plexus-utils makes sense then on how to evolve plexus-xml extracted from plexus-utils with the rewrite for Maven 4, good question first issue created codehaus-plexus/plexus-utils#228 |
+1 for maven to ingest used plexus classes rather than working on plexus off radars for the long term (probably lazily, ie each time we need a change we rather import the lib instead of patching+releasing it). |
oh, back to plexus-utils https://codehaus-plexus.github.io/plexus-utils/ vs maven-shared-utils https://maven.apache.org/shared/maven-shared-utils/ discussion I suppose we can split maven-shared-utils 3 into maven-shared-xml 4 + maven-shared-utils 4 using maven-shared-utils 4 instead of plexus-utils 4 in Maven core is not an issue but switching to maven-shared-xml 4 is not possible, because there is a java package change from plexus-xml 4 |
ok, launching some feedback on the Maven dev ML for plexus-xml: this looks simple and wold make things much cleaner = Plexus plexus-utils 4 is used as is (and eventually migrated away), and there is only the plexus-xml reimplementation as maven-plexus-xml |
Superseded by #1093 |
https://issues.apache.org/jira/browse/MNG-7655
keeping
plexus-utils
artifactId withorg.apache.maven
vsorg.codehaus.plexus
groupId is confusing: let's name itmaven-plexus-utils
and
maven-xml-impl
is better namedmaven-plexus-utils-xml
, to show that it reimplements plexus-utils' content