READ default mode in SftpFileSystemProvider.newFileChannel() (#372)

According to upstream javadoc, the default mode is READ (only) when there is no mode specified.

sshd-sftp/src/main/java/org/apache/sshd/sftp/client/fs/SftpFileSystemProvider.java

@@ -579,7 +579,7 @@ public FileChannel newFileChannel(Path path, Set<? extends OpenOption> options,
  throws IOException {
  Collection<OpenMode> modes = OpenMode.fromOpenOptions(options);
  if (modes.isEmpty()) {
- modes = EnumSet.of(OpenMode.Read, OpenMode.Write);
+ modes = EnumSet.of(OpenMode.Read);
  }
  // TODO: process file attributes
  SftpPath p = toSftpPath(path);

sshd-sftp/src/test/java/org/apache/sshd/sftp/client/fs/AbstractSftpFilesSystemSupport.java

@@ -33,6 +33,7 @@
 import java.nio.file.NoSuchFileException;
 import java.nio.file.Path;
 import java.nio.file.StandardCopyOption;
+import java.nio.file.StandardOpenOption;
 import java.nio.file.attribute.AclEntry;
 import java.nio.file.attribute.AclFileAttributeView;
 import java.util.Collections;
@@ -189,11 +190,11 @@ protected static void testSymbolicLinks(Path link, Path relPath) throws IOExcept
  }
 
  protected static void testFileChannelLock(Path file) throws IOException {
- try (FileChannel channel = FileChannel.open(file)) {
+ try (FileChannel channel = FileChannel.open(file, StandardOpenOption.WRITE)) {
  try (FileLock lock = channel.lock()) {
  outputDebugMessage("Lock %s: %s", file, lock);
 
- try (FileChannel channel2 = FileChannel.open(file)) {
+ try (FileChannel channel2 = FileChannel.open(file, StandardOpenOption.WRITE)) {
  try (FileLock lock2 = channel2.lock()) {
  fail("Unexpected success in re-locking " + file + ": " + lock2);
  } catch (OverlappingFileLockException e) {