-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Snapshot builds of current master #356
Comments
Good idea. I haven't found any proper documentation, but reading through a number of support tickets at the ASF it looks as if such credentials already exist. I have opened https://issues.apache.org/jira/browse/INFRA-24609 to get some help. Not that we run off in the wrong direction :-) Of course snapshots should only be published if the compile/test workflows succeeded, and only if it's indeed a -SNAPSHOT version. Also not on PRs. Would we have to be careful about multiple builds on master running concurrently and then trying to deploy concurrently? |
Great, thanks.
Yes, definitivly but that can be managed by using corresponding event filters.
We can just abort concurrently running deploy builds using To reduce the risik of partial deployments we can use deployAtEnd of the maven-deploy-plugin. |
The two secrets are named NEXUS_USER and NEXUS_PW. They have been enabled now for this repository. Apparently that is all we need, so we can go forward with this. |
Great. 👍🏽 |
On pushes to the master branch, publish snapshot artifacts to the Apache snapshot repo if the tests were successful. Do nothing for release versions; releases are prepared manually and go through the normal Apache process (staging, voting) before being released. Snapshots are not and do not have to be signed according to [1]. The deployment jobs are serialized, and they deploy only if * the project is indeed a -SNAPSHOT version * the current master branch has not advanced * the commit message does not start with "[maven-release-plugin]" [1] https://issues.apache.org/jira/browse/INFRA-24609 Bug: #356
YAML handles ! specially. Quote the expressions containing exclamation marks.
Somehow the continuation lines did't work. No idea why.
Also mention where to find snapshot releases.
Done. Here's what I came up with: diff. I hate yaml. A first snapshot release is published already at the Apache Snapshots repo. |
Split the single workflow into two workflows: a compile-test workflow that runs on PRs and that can be called from master-build, which additionally deploys snapshots. That way we never have to worry about a PR build inadvertently trying to deploy.
Split the single workflow into two workflows: a build workflow that compiles and tests and that runs on PRs and that can be called from master-build, which additionally deploys snapshots. That way we never have to worry about a PR build inadvertently trying to deploy.
Great. Thank you! |
Description
Please publish snapshot builds of the current master.
The artifacts produced by the Github workflows on a push to the master could just be deployed to https://repository.apache.org/content/repositories/snapshots.
The apache 23 parent pom already has the
apache.snapshots.https
snapshotRepository
defined.Therefore, as described in the GitHub documentation about publishing-java-packages-with-maven,
only another deploy job would have to be added that deploys the artifacts created by the first compile job.
I could provide a PR to implement that. The only thing you would have to do is to store the credentials for the apache snapshots repository in this repositories secret store and tell me the variable names so that it can be refered to when setting up the
server-username
andserver-password
.Motivation
Providing Snapshot builds of the current master-branch allows early testing and feedback of new changes.
Alternatives considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: