Create Nio2Session using Nio2ServiceFactory #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows client code to override and extend the Nio2Session class. Current implementation creates createWriteCycleCompletionHandler which executes OS callback and completes the future on another thread. The overridden implementation may wrap the callbacks with custom code and set up, for example, the logging MDC
odl-github
pushed a commit
to opendaylight/netconf
that referenced
this pull request
Mar 27, 2024
Adapt SshProxyServer to deal with apache/mina-sshd#424 JIRA: NETCONF-1267 Change-Id: I254c8fa2563553a22e3197b658bb0c367c51e232 Signed-off-by: Matej Sramcik <matej.sramcik@pantheon.tech>
odl-github
pushed a commit
to opendaylight/netconf
that referenced
this pull request
Mar 27, 2024
Adapt SshProxyServer to deal with apache/mina-sshd#424 JIRA: NETCONF-1267 Change-Id: I254c8fa2563553a22e3197b658bb0c367c51e232 Signed-off-by: Matej Sramcik <matej.sramcik@pantheon.tech>
odl-github
pushed a commit
to opendaylight/netconf
that referenced
this pull request
Mar 27, 2024
Adapt SshProxyServer to deal with apache/mina-sshd#424 JIRA: NETCONF-1267 Change-Id: I254c8fa2563553a22e3197b658bb0c367c51e232 Signed-off-by: Matej Sramcik <matej.sramcik@pantheon.tech>
odl-github
pushed a commit
to opendaylight/netconf
that referenced
this pull request
Apr 25, 2024
Adapt SshProxyServer to deal with apache/mina-sshd#424 JIRA: NETCONF-1267 Change-Id: I254c8fa2563553a22e3197b658bb0c367c51e232 Signed-off-by: Matej Sramcik <matej.sramcik@pantheon.tech>
odl-github
pushed a commit
to opendaylight/netconf
that referenced
this pull request
Apr 25, 2024
Adapt SshProxyServer to deal with apache/mina-sshd#424 JIRA: NETCONF-1267 Change-Id: I254c8fa2563553a22e3197b658bb0c367c51e232 Signed-off-by: Matej Sramcik <matej.sramcik@pantheon.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows client code to override and extend the Nio2Session class. Current implementation creates createWriteCycleCompletionHandler which executes OS callback and completes the future on another thread. The overridden implementation may wrap the callbacks with custom code and set up, for example, the logging MDC