DIRMINA-1173

.gitignore

@@ -12,5 +12,4 @@ bin/
 .clover
 META-INF/
 Dockerfile
-Jenkinsfile
 /.idea/

Jenkinsfile

@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+pipeline {
+  agent none
+  options {
+    buildDiscarder(logRotator(numToKeepStr: '10'))
+    timeout(time: 8, unit: 'HOURS')
+  }
+  tools {
+    maven 'maven_3_latest'
+    jdk params.jdkVersion
+  }
+  options {
+      // Configure an overall timeout for the build of ten hours.
+      timeout(time: 20, unit: 'HOURS')
+      // When we have test-fails e.g. we don't need to run the remaining steps
+      buildDiscarder(logRotator(numToKeepStr: '5', artifactNumToKeepStr: '5'))
+      disableConcurrentBuilds()
+  }
+  parameters {
+      choice(name: 'nodeLabel', choices: ['ubuntu', 'arm', 'Windows']) 
+      choice(name: 'jdkVersion', choices: ['jdk_8_latest', 'jdk_11_latest', 'jdk_17_latest', 'jdk_21_latest', 'jdk_22_latest', 'jdk_8_latest_windows', 'jdk_11_latest_windows', 'jdk_17_latest_windows', 'jdk_21_latest_windows', 'jdk_22_latest_windows']) 
+      booleanParam(name: 'deployEnabled', defaultValue: false)
+      booleanParam(name: 'sonarEnabled', defaultValue: false)
+      booleanParam(name: 'testsEnabled', defaultValue: true)
+  }
+
+  triggers {
+    cron('@weekly')
+    pollSCM('@daily')
+  }
+  stages {
+    stage('Initialization') {
+      steps {
+        echo "running on ${env.NODE_NAME}"
+        echo 'Building branch ' + env.BRANCH_NAME
+        echo 'Using PATH ' + env.PATH
+      }
+    }
+
+    stage('Cleanup') {
+      steps {
+        echo 'Cleaning up the workspace'
+        deleteDir()
+      }
+    }
+
+    stage('Checkout') {
+      steps {
+        echo 'Checking out branch ' + env.BRANCH_NAME
+        checkout scm
+      }
+    }
+
+    stage('Build JDK 22') {
+      tools {
+        jdk "jdk_22_latest"
+      }
+      steps {
+        echo 'Building JDK 22'
+        sh 'java -version'
+        sh 'mvn -version'
+        sh 'mvn clean install -Pserial'
+      }
+    }
+
+    stage('Build JDK 21') {
+      tools {
+        jdk "jdk_21_latest"
+      }
+      steps {
+        echo 'Building JDK 21'
+        sh 'java -version'
+        sh 'mvn -version'
+        sh 'mvn clean install -Pserial'
+      }
+    }
+
+    stage('Build JDK 17') {
+      tools {
+        jdk "jdk_17"
+      }
+      steps {
+        echo 'Building JDK 17'
+        sh 'java -version'
+        sh 'mvn -version'
+        sh 'mvn clean install -Pserial'
+      }
+    }
+
+    stage('Build JDK 11') {
+      tools {
+        jdk "jdk_11"
+      }
+      steps {
+        echo 'Building JDK 11'
+        sh 'java -version'
+        sh 'mvn -version'
+        sh 'mvn clean install -Pserial'
+      }
+    }
+
+    stage('Build JDK 8') {
+      tools {
+        jdk "jdk_8"
+      }
+      steps {
+        echo 'Building JDK 8'
+        sh 'java -version'
+        sh 'mvn -version'
+        sh 'mvn clean install -Pserial'
+      }
+    }
+  }
+}

mina-core/src/main/java/org/apache/mina/core/future/DefaultIoFuture.java

@@ -22,6 +22,7 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
 
 import org.apache.mina.core.polling.AbstractPollingIoProcessor;
 import org.apache.mina.core.service.IoProcessor;
@@ -55,7 +56,7 @@ public class DefaultIoFuture implements IoFuture {
     private Object result;
 
     /** The flag used to determinate if the Future is completed or not */
-    private boolean ready;
+    private AtomicBoolean ready = new AtomicBoolean(false);
 
     /** A counter for the number of threads waiting on this future */
     private int waiters;
@@ -102,7 +103,7 @@ public boolean join(long timeoutMillis) {
     @Override
     public IoFuture await() throws InterruptedException {
         synchronized (lock) {
-            while (!ready) {
+            while (!ready.get()) {
                 waiters++;
 
                 try {
@@ -113,7 +114,7 @@ public IoFuture await() throws InterruptedException {
                 } finally {
                     waiters--;
 
-                    if (!ready) {
+                    if (!ready.get()) {
                         checkDeadLock();
                     }
                 }
@@ -200,8 +201,8 @@ private boolean await0(long timeoutMillis, boolean interruptable) throws Interru
         synchronized (lock) {
             // We can quit if the ready flag is set to true, or if
             // the timeout is set to 0 or below : we don't wait in this case.
-            if (ready||(timeoutMillis <= 0)) {
-                return ready;
+            if (ready.get()||(timeoutMillis <= 0)) {
+                return ready.get();
             }
 
             // The operation is not completed : we have to wait
@@ -222,8 +223,8 @@ private boolean await0(long timeoutMillis, boolean interruptable) throws Interru
                         }
                     }
 
-                    if (ready || (endTime < System.currentTimeMillis())) {
-                        return ready;
+                    if (ready.get() || (endTime < System.currentTimeMillis())) {
+                        return ready.get();
                     } else {
                         // Take a chance, detect a potential deadlock
                         checkDeadLock();
@@ -237,7 +238,7 @@ private boolean await0(long timeoutMillis, boolean interruptable) throws Interru
                 // In any case, we decrement the number of waiters, and we get out.
                 waiters--;
 
-                if (!ready) {
+                if (!ready.get()) {
                     checkDeadLock();
                 }
             }
@@ -295,9 +296,7 @@ private void checkDeadLock() {
      */
     @Override
     public boolean isDone() {
-        synchronized (lock) {
-            return ready;
-        }
+        return ready.get();
     }
 
     /**
@@ -310,12 +309,12 @@ public boolean isDone() {
     public boolean setValue(Object newValue) {
         synchronized (lock) {
             // Allowed only once.
-            if (ready) {
+            if (ready.get()) {
                 return false;
             }
 
             result = newValue;
-            ready = true;
+            ready.set(true);
 
             // Now, if we have waiters, notify them that the operation has completed
             if (waiters > 0) {
@@ -348,7 +347,7 @@ public IoFuture addListener(IoFutureListener<?> listener) {
         }
 
         synchronized (lock) {
-            if (ready) {
+            if (ready.get()) {
                 // Shortcut : if the operation has completed, no need to 
                 // add a new listener, we just have to notify it. The existing
                 // listeners have already been notified anyway, when the 
@@ -380,7 +379,7 @@ public IoFuture removeListener(IoFutureListener<?> listener) {
         }
 
         synchronized (lock) {
-            if (!ready) {
+            if (!ready.get()) {
                 if (listener == firstListener) {
                     if ((otherListeners != null) && !otherListeners.isEmpty()) {
                         firstListener = otherListeners.remove(0);

mina-core/src/main/java/org/apache/mina/core/service/IoServiceListenerSupport.java

@@ -252,9 +252,9 @@ public void fireSessionDestroyed(IoSession session) {
 
         // Fire listener events.
         try {
-            for (IoServiceListener l : listeners) {
+            for (IoServiceListener listener : listeners) {
                 try {
-                    l.sessionDestroyed(session);
+                    listener.sessionDestroyed(session);
                 } catch (Exception e) {
                     ExceptionMonitor.getInstance().exceptionCaught(e);
                 }

mina-core/src/main/java/org/apache/mina/filter/codec/CumulativeProtocolDecoder.java

@@ -169,6 +169,12 @@ public void decode(IoSession session, IoBuffer in, ProtocolDecoderOutput out) th
                 buf = newBuf;
 
                 // Update the session attribute.
+                IoBuffer oldBuf = (IoBuffer) session.getAttribute(BUFFER);
+
+                if (oldBuf != null) { 
+                    oldBuf.free();
+                }
+
                 session.setAttribute(BUFFER, buf);
             }
         } else {
@@ -236,6 +242,7 @@ public void dispose(IoSession session) throws Exception {
 
     private void removeSessionBuffer(IoSession session) {
         IoBuffer buf = (IoBuffer) session.removeAttribute(BUFFER);
+
         if (buf != null) {
             buf.free();
         }
@@ -247,6 +254,12 @@ private void storeRemainingInSession(IoBuffer buf, IoSession session) {
         remainingBuf.order(buf.order());
         remainingBuf.put(buf);
 
+        IoBuffer oldBuf = (IoBuffer) session.getAttribute(BUFFER);
+
+        if (oldBuf != null) {
+            oldBuf.free();
+        }
+
         session.setAttribute(BUFFER, remainingBuf);
     }
 

mina-core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java

@@ -273,6 +273,8 @@ public void messageReceived(final NextFilter nextFilter, final IoSession session
                 }
             }
         }
+
+        in.free();
     }
 
     /**

mina-core/src/main/java/org/apache/mina/filter/ssl/SSLHandlerG0.java

@@ -136,7 +136,7 @@ synchronized public void open(NextFilter next) throws SSLException {
 
             if (mEngine.getUseClientMode()) {
                 if (LOGGER.isDebugEnabled()) {
-                    LOGGER.debug("{} open() - begin handshaking", toString());
+                    LOGGER.debug("{} open() - begin handshaking", this);
                 }
 
                 mEngine.beginHandshake();
@@ -252,7 +252,7 @@ protected void receive_loop(NextFilter next, IoBuffer message) throws SSLExcepti
                     LOGGER.debug("{} receive_loop() - handshake needs task, scheduling", toString());
                 }
 
-                execute_task(next);
+                schedule_task(next);
 
                 break;
             case NEED_WRAP: