Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Inconsistent naming of pow/power between mx.symbol and mx.nd #14602

Closed
YutingZhang opened this issue Apr 3, 2019 · 7 comments
Closed

Inconsistent naming of pow/power between mx.symbol and mx.nd #14602

YutingZhang opened this issue Apr 3, 2019 · 7 comments
Labels
Bug Operator

Comments

@YutingZhang
Copy link
Contributor

mx.nd.pow and mx.symbol.power are named inconsistently. As a result, in a HybridBlock, one cannot do F.pow or F.powerl directly.
@haojin2
Copy link
Contributor

haojin2 commented Apr 3, 2019

It's indeed a problem... To ensure backward compatibility I'll add both nd.power and sym.pow. How do you like such a fix?

@haojin2 haojin2 added the Bug label Apr 3, 2019
@YutingZhang
Copy link
Contributor Author

@haojin2 That'll be perfect! Thanks!

@haojin2
Copy link
Contributor

haojin2 commented Apr 3, 2019

@YutingZhang WIP, will let you know when the PR is out, should be within today.

@haojin2 haojin2 mentioned this issue Apr 3, 2019
Merged
8 tasks
@haojin2
Copy link
Contributor

haojin2 commented Apr 3, 2019

@YutingZhang Fix in #14606

@abhinavs95
Copy link
Contributor

@mxnet-label-bot update [Bug, operator]

@haojin2
Copy link
Contributor

haojin2 commented Apr 11, 2019

@YutingZhang Fix merged. Please let me know if the latest master solves your issue.

@YutingZhang
Copy link
Contributor Author

Thanks! @haojin2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Operator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@YutingZhang @haojin2 @marcoabreu @abhinavs95