Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add nd.power and sym.pow #14606

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Add nd.power and sym.pow #14606

merged 2 commits into from
Apr 11, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Apr 3, 2019

Description

Address #14602.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Add nd.power in frontend
  • Add sym.pow in frontend
  • Add unit test coverage

Comments

@YutingZhang

@haojin2 haojin2 requested a review from szha as a code owner April 3, 2019 06:03
@haojin2 haojin2 added the pr-awaiting-review PR is waiting for code review label Apr 3, 2019
@haojin2
Copy link
Contributor Author

haojin2 commented Apr 3, 2019

@szha for review.

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for your contribution!
Can we add an alias for pow operator in C++ backend?

@haojin2
Copy link
Contributor Author

haojin2 commented Apr 8, 2019

@wkcn @eric-haibin-lin @szha Please review.

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: ) Thank you for the quick fix!

@eric-haibin-lin
Copy link
Member

Can you rebase with master to skip the TRT flaky test?

@haojin2
Copy link
Contributor Author

haojin2 commented Apr 9, 2019

@eric-haibin-lin Done.

@haojin2 haojin2 merged commit 596ef3a into apache:master Apr 11, 2019
@haojin2 haojin2 deleted the fix_power branch April 11, 2019 21:53
larroy pushed a commit to larroy/mxnet that referenced this pull request Apr 15, 2019
* add nd.power and sym.pow

* deprecate sym.pow, get rid of nd.pow
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* add nd.power and sym.pow

* deprecate sym.pow, get rid of nd.pow
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants