Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

gluon.Block.load_params set the default ctx to cpu #10160

Merged
merged 2 commits into from
Mar 20, 2018
Merged

gluon.Block.load_params set the default ctx to cpu #10160

merged 2 commits into from
Mar 20, 2018

Conversation

mli
Copy link
Contributor

@mli mli commented Mar 19, 2018

Description

It's convenience to just have

net.save_params('net.params')
net.load_params('net.params')

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

It's convenience to just have

```python
net.save_params('net.params')
net.load_params('net.params')
```
@mli mli requested a review from szha as a code owner March 19, 2018 21:03
@@ -299,7 +300,7 @@ def save_params(self, filename):
"""
self.collect_params().save(filename, strip_prefix=self.prefix)

def load_params(self, filename, ctx, allow_missing=False,
def load_params(self, filename, ctx=cpu(), allow_missing=False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update api doc with the new default value.

@piiswrong piiswrong merged commit f2e08cf into apache:master Mar 20, 2018
ashokei pushed a commit to ashokei/incubator-mxnet that referenced this pull request Mar 27, 2018
* `gluon.Block.load_params` set the default `ctx` to cpu

It's convenience to just have

```python
net.save_params('net.params')
net.load_params('net.params')
```

* Update block.py
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request Mar 30, 2018
* `gluon.Block.load_params` set the default `ctx` to cpu

It's convenience to just have

```python
net.save_params('net.params')
net.load_params('net.params')
```

* Update block.py
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
* `gluon.Block.load_params` set the default `ctx` to cpu

It's convenience to just have

```python
net.save_params('net.params')
net.load_params('net.params')
```

* Update block.py
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* `gluon.Block.load_params` set the default `ctx` to cpu

It's convenience to just have

```python
net.save_params('net.params')
net.load_params('net.params')
```

* Update block.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants