Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-128] added load from buffer functions #10261

Merged
merged 3 commits into from
Apr 3, 2018

Conversation

dabraude
Copy link
Contributor

@dabraude dabraude commented Mar 27, 2018

Description

(resubmitted due to merge issues)

Added load from function buffers for CPP package

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Added equivalent functions for the loading, from buffers instead of files

Comments

  • Duplicates functionality from Python wrapper

@dabraude
Copy link
Contributor Author

@cjolivier01 had to sort out a bunch of merge issues with 3rd party hence the resubmit from
PR #10199

@dabraude
Copy link
Contributor Author

I'll point out that the tests that failed are in the Python wrappers, if you like I can put in tickets about them being flaky

@dabraude
Copy link
Contributor Author

nvidia-docker run --rm

seems to be causing issues

Mainly done to get to retest
@dabraude
Copy link
Contributor Author

@cjolivier01 passed all tests and good to be merged

@dabraude
Copy link
Contributor Author

dabraude commented Apr 3, 2018

Hey @cjolivier01 I was wondering if I needed to do something else to get this merged?

@cjolivier01
Copy link
Member

ok

@cjolivier01 cjolivier01 merged commit a157d17 into apache:master Apr 3, 2018
@dabraude
Copy link
Contributor Author

dabraude commented Apr 3, 2018

Awesome thanks

@dabraude dabraude deleted the cpp_ndarray_loadfrombuffer branch April 3, 2018 21:16
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
* rebased on master

* Update ndarray.h

* clairified comment

Mainly done to get to retest
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* rebased on master

* Update ndarray.h

* clairified comment

Mainly done to get to retest
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants