Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add support for cast storage on same stypes #10400

Merged
merged 7 commits into from
Apr 5, 2018
Merged

Add support for cast storage on same stypes #10400

merged 7 commits into from
Apr 5, 2018

Conversation

anirudh2290
Copy link
Member

Description

Fixes #8524

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin self-assigned this Apr 4, 2018
eric-haibin-lin
eric-haibin-lin reviewed Apr 4, 2018
View reviewed changes
Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good. Thanks for the fix!!

src/operator/tensor/cast_storage-inl.h Outdated
if (!rsp.storage_initialized()) {
FillZerosRspImpl(s, *output);
return;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation?

src/operator/tensor/cast_storage-inl.h Outdated
FillZerosCsrImpl(s, *output);
return;
}
output->CheckAndAllocAuxData(csr::kIndPtr, csr.aux_shape(csr::kIndPtr));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: CheckAndAlloc(const std::vector<TShape> &aux_shapes) will make it neater..

@eric-haibin-lin
Copy link
Member

Do you mind also updating the doc for the added support? https://mxnet.incubator.apache.org/versions/master/api/python/ndarray/sparse.html#mxnet.ndarray.sparse.cast_storage ?

@anirudh2290
Copy link
Member Author

@eric-haibin-lin Addressed.

@haojin2
Copy link
Contributor

haojin2 commented Apr 5, 2018

LGTM!

@eric-haibin-lin eric-haibin-lin merged commit 2cd09a0 into apache:master Apr 5, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
@anirudh2290 @eric-haibin-lin
Add support for cast storage on same stypes (apache#10400)
51841e7 
* Add cast storage support for same stypes

* Add imports

* Fix cast

* Fix doc for cast_storage

* Fix
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@anirudh2290 @zheng-da
Add support for cast storage on same stypes (apache#10400)
ab47a5b 
* Add cast storage support for same stypes

* Add imports

* Fix cast

* Fix doc for cast_storage

* Fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-haibin-lin eric-haibin-lin eric-haibin-lin left review comments

@cjolivier01 cjolivier01 Awaiting requested review from cjolivier01

Assignees

@eric-haibin-lin eric-haibin-lin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cast storage to same stype gives an error for csr
3 participants
@anirudh2290 @eric-haibin-lin @haojin2