This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-283] Error handling for non-positive reps of tile op #10417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiswrong
suggested changes
Apr 5, 2018
src/operator/tensor/matrix_op-inl.h
Outdated
| @@ -1462,6 +1463,10 @@ inline bool TileOpShape(const nnvm::NodeAttrs& attrs, | |||
| SHAPE_ASSIGN_CHECK(*out_attrs, 0, ishape); | |||
| return true; | |||
| } | |||
| // fix for https://github.com/apache/incubator-mxnet/issues/10288 | |||
There was a problem hiding this comment.
no need to put this in comment
| def test_zero_reps(): | ||
| a = np.array([[2, 3, 4], [5, 6, 7]], dtype=np.int32) | ||
| b = mx.nd.array(a, ctx=default_context(), dtype=a.dtype) | ||
| reps = (2, 0, 4, 5) |
There was a problem hiding this comment.
why was this supported previously? What was the behavior?
There was a problem hiding this comment.
It would return an empty NDArray with some dim size equal to zero. I was following the NumPy's convention to implement the behavior. Since MXNet does not support empty NDArrays in any way, I think it's okay to move this to assert_exception test?
src/operator/tensor/matrix_op-inl.h
Outdated
| @@ -1462,6 +1463,10 @@ inline bool TileOpShape(const nnvm::NodeAttrs& attrs, | |||
| SHAPE_ASSIGN_CHECK(*out_attrs, 0, ishape); | |||
| return true; | |||
| } | |||
| // fix for https://github.com/apache/incubator-mxnet/issues/10288 | |||
| for (size_t i = 0; i < reps.ndim(); ++i) { | |||
| CHECK_GT(reps[i], 0) << "invalid reps[" << i << "], dim size must be greater than zero"; | |||
There was a problem hiding this comment.
"invalid reps=i" instead of "invalid reps[i]"
reminisce
force-pushed
the
add_error_handling_for_reps_tile_op
branch
from
392e834
to
49e69ad
Compare
reminisce
changed the title
|
@piiswrong is this good to merge ? |
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
…0417) * Error handling for non-positive reps of tile op * Address cr * Fix unit test
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
…0417) * Error handling for non-positive reps of tile op * Address cr * Fix unit test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address this issue.
#10288
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments