Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Remove Fermi from cmake #10486

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Remove Fermi from cmake #10486

merged 1 commit into from
Apr 11, 2018

Conversation

cjolivier01
Copy link
Member

@cjolivier01 cjolivier01 commented Apr 10, 2018 •
edited
Loading

Description

Fermi architecture is no longer supported

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@cjolivier01 cjolivier01 requested a review from szha as a code owner April 10, 2018 19:29
@anirudh2290
Copy link
Member

@piiswrong @marcoabreu can we merge this ?

@marcoabreu
Copy link
Contributor

LGTM.

Should we add Pascal and Volta to the list?

@cjolivier01
Copy link
Member Author

It adds up to 6.1 in the lines after that. This is just the unconditioned baseline list. Someone could add "Volta" if they want down the line, but I think that's 6.1, right?

@cjolivier01 cjolivier01 merged commit 55e7435 into apache:master Apr 11, 2018
@cjolivier01 cjolivier01 deleted the issue_187_1 branch April 11, 2018 15:08
@marcoabreu
Copy link
Contributor

marcoabreu commented Apr 11, 2018 via email

dabraude pushed a commit to dabraude/incubator-mxnet that referenced this pull request Apr 12, 2018
@cjolivier01 @dabraude
Remove Fermi from cmake (apache#10486)
095f4bc
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
@cjolivier01
Remove Fermi from cmake (apache#10486)
1a65402
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@cjolivier01 @zheng-da
Remove Fermi from cmake (apache#10486)
b7597a2
piiswrong pushed a commit that referenced this pull request Jun 28, 2018
@dabraude @piiswrong
[MXNET-312] Added Matthew's Correlation Coefficient to metrics (#10524)
044afa3 
* Remove Fermi from cmake (#10486)

* updated R docs (#10473)

* [MXNET-120] Float16 support for distributed training (#10183)

* send as char

* fix bug on pull response, and rowsparse on worker side

* three modes

* default to mode 0 and add support for row sparse

* refactor sparse

* rowsparse numbytes fixes

* WIP tests

* update test sync

* remove prints

* refactoring

* Revert "refactoring"

This reverts commit 05ffa1b.

* undo refactoring to keep PR simple

* add wait to stored in pull default

* lint fixes

* undo static cast for recvblob

* lint fixes

* mode 1 changes

* sparse bug fix dtype

* mshadow default

* remove unused var

* remove debug statements

* clearer variables, reduced multiplication, const vars

* add const for more vars, comments

* comment syntax, code watcher, test default val

* remove unnecessary print in test

* trigger ci

* multi precision mode (debugging race condition)

* working rsp pushes

* finish multiprecision for row sparse

* rename num-bytes

* fix bug due to rename of numbytes, and remove debug logs

* address comments

* add integration test

* trigger ci

* integration test

* integration test

* fix path of script

* update mshadow

* disable f16c for amalgamation

* fix amalgamation build

* trigger ci

* disable f16c for jetson

* Fix rat excludes (#10499)

* MXNET-308 added missing license (#10497)

* refactored example (#10484)

* [MXNET-298] Scala Infer API docs landing page (#10474)

* changed url references from dmlc to apache/incubator-mxnet

* prepping scala landing pages

* infer api info added

* Fix infer storage type (#10507)

* Fix infer_storage_type

* Add test

* Fix lint

* Trigger CI

* [MXNET-306] Add slice_like operator (#10491)

* add slice_like and doc

* pass unittest and lint

* Minor simplifications in ci/build.py (#10496)

* [MXNET-305] Scala tutorial table fix (#10488)

* initial update on setting up scala ide with mxnet

* moving images to web-data project

* updated links to images; added readme for root folder

* scala hello world feature added

* workaround for make transitive error

* fixed systempath

* minor updates

* table fix

* added some spacing

* more spacing

* added ability to set search path for Accelerate library

* [MXNET-311] change test needs a docker with sudo, hence image changed (#10510)

* added new metric

* changed back from branch to upstream

* lint changed

* Fixed typo

* Clarified interpretation

* Changes for variable names

* fixed variable names

* replay the unit tests

* changed comment
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@dabraude @piiswrong
[MXNET-312] Added Matthew's Correlation Coefficient to metrics (apach…
f6b6a98 
…e#10524)

* Remove Fermi from cmake (apache#10486)

* updated R docs (apache#10473)

* [MXNET-120] Float16 support for distributed training (apache#10183)

* send as char

* fix bug on pull response, and rowsparse on worker side

* three modes

* default to mode 0 and add support for row sparse

* refactor sparse

* rowsparse numbytes fixes

* WIP tests

* update test sync

* remove prints

* refactoring

* Revert "refactoring"

This reverts commit 05ffa1b.

* undo refactoring to keep PR simple

* add wait to stored in pull default

* lint fixes

* undo static cast for recvblob

* lint fixes

* mode 1 changes

* sparse bug fix dtype

* mshadow default

* remove unused var

* remove debug statements

* clearer variables, reduced multiplication, const vars

* add const for more vars, comments

* comment syntax, code watcher, test default val

* remove unnecessary print in test

* trigger ci

* multi precision mode (debugging race condition)

* working rsp pushes

* finish multiprecision for row sparse

* rename num-bytes

* fix bug due to rename of numbytes, and remove debug logs

* address comments

* add integration test

* trigger ci

* integration test

* integration test

* fix path of script

* update mshadow

* disable f16c for amalgamation

* fix amalgamation build

* trigger ci

* disable f16c for jetson

* Fix rat excludes (apache#10499)

* MXNET-308 added missing license (apache#10497)

* refactored example (apache#10484)

* [MXNET-298] Scala Infer API docs landing page (apache#10474)

* changed url references from dmlc to apache/incubator-mxnet

* prepping scala landing pages

* infer api info added

* Fix infer storage type (apache#10507)

* Fix infer_storage_type

* Add test

* Fix lint

* Trigger CI

* [MXNET-306] Add slice_like operator (apache#10491)

* add slice_like and doc

* pass unittest and lint

* Minor simplifications in ci/build.py (apache#10496)

* [MXNET-305] Scala tutorial table fix (apache#10488)

* initial update on setting up scala ide with mxnet

* moving images to web-data project

* updated links to images; added readme for root folder

* scala hello world feature added

* workaround for make transitive error

* fixed systempath

* minor updates

* table fix

* added some spacing

* more spacing

* added ability to set search path for Accelerate library

* [MXNET-311] change test needs a docker with sudo, hence image changed (apache#10510)

* added new metric

* changed back from branch to upstream

* lint changed

* Fixed typo

* Clarified interpretation

* Changes for variable names

* fixed variable names

* replay the unit tests

* changed comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anirudh2290 anirudh2290 anirudh2290 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjolivier01 @anirudh2290 @marcoabreu