Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

MXNET-650 [Perl] Gluon ModelZoo, Gluon examples #11642

Merged
merged 7 commits into from
Jul 13, 2018

Conversation

sergeykolychev
Copy link
Contributor

@sergeykolychev sergeykolychev commented Jul 11, 2018

Description

  1. Added Gluon Contrib modules
  2. Added Gluon Model Zoo
  3. Added Gluon image classification and style transfer examples
  4. Miscellaneous bugfixes and improvements.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  1. Added Gluon Contrib modules
  2. Added Gluon Model Zoo
  3. Added Gluon image classification and style transfer examples
  4. Miscellaneous bugfixes and improvements.

Comments

1) Added Gluon Contrib modules
2) Added Gluon Model Zoo
3) Added Gluon image classification and style transfer examples
4) Miscellaneous bugfixes and improvements.
@sergeykolychev
Copy link
Contributor Author

@tlby
Robert, could you please review this one, thanks!

Copy link
Contributor

@tlby tlby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fairly straightforward and I didn't find any surprises. nice work!


GetOptions(
## my Pembroke Welsh Corgi Kyuubi, enjoing Solar eclipse of August 21, 2017
'image=s' => \(my $image = 'https://scontent-sea1-1.cdninstagram.com/vp/'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆
How long does this pic persist on the CDN of instagram? Will the link expire?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szha I am not sure.
But I'll be glad if I can put this image on mxnet data server. Besides that I have a few blog posts that I want in future to have added as a tutorials for perl api
http://blogs.perl.org/users/sergey_kolychev/, they do contain some images and data files that would be nice to have on mxnet data server as well.
I'll be writing new blog post soon announcing ModelZoo for perl and I'll use images from https://www.facebook.com/sergey.kolychev.39/posts/10155737425303434.
Can you help me with putting these images/data files to the server ?
Or may be I can get a write access somehow so I'll not bother you with this ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sergeykolychev
Copy link
Contributor Author

@szha Thank you! I'll update the file with new uri. When you have time could you, please, upload the images from that facebook post as well ? I'll then change stock images with Kyuubi's images for the style transfer example cause they are quite a bit cutier :-)

@sergeykolychev sergeykolychev merged commit de2edc7 into apache:master Jul 13, 2018
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
* MXNET-650
1) Added Gluon Contrib modules
2) Added Gluon Model Zoo
3) Added Gluon image classification and style transfer examples
4) Miscellaneous bugfixes and improvements.

* added license.

* a few typos/bugfix/doc improvement.

* switched default images for the style transfer example for images of my cute dog.
optimized image_classification.pl script a bit.

* fixed readme.

* using static seed in the perl space as well (shiffling in NDArrayIter) to provide consistence in the loss tests.

* additional pythonification.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants